Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persistent delay buffer to correctly run slayer blocks one timestep at a time #169

Merged
merged 38 commits into from Mar 3, 2023

Conversation

bamsumit
Copy link
Contributor

@bamsumit bamsumit commented Mar 2, 2023

Issue Number: 168

Objective of pull request:
Enable slayer blocks to run correctly when run one timestep at a time.

Pull request checklist

Your PR fulfills the following requirements:

  • Issue created that explains the change and why it's needed
  • Tests are part of the PR (for bug fixes / features)
  • Docs reviewed and added / updated if needed (for bug fixes / features)
  • PR conforms to Coding Conventions
  • PR applys BSD 3-clause or LGPL2.1+ Licenses to all code files
  • Lint (flakeheaven lint src/lava tests/) and (bandit -r src/lava/.) pass locally
  • Build tests (pytest) passes locally

Pull request type

Please check your PR type:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation changes
  • Other (please describe):

What is the current behavior?

  • Slayer blocks don't run correctly when run one timestep at a time.

What is the new behavior?

  • Slayer blocks run correctly when run one timestep at a time.

Does this introduce a breaking change?

  • Yes
  • No

Supplemental information

Signed-off-by: bamsumit <bam_sumit@hotmail.com>
Signed-off-by: bamsumit <bam_sumit@hotmail.com>
Signed-off-by: bamsumit <bam_sumit@hotmail.com>
Signed-off-by: bamsumit <bam_sumit@hotmail.com>
Signed-off-by: bamsumit <bam_sumit@hotmail.com>
Signed-off-by: bamsumit <bam_sumit@hotmail.com>
Signed-off-by: bamsumit <bam_sumit@hotmail.com>
Signed-off-by: bamsumit <bam_sumit@hotmail.com>
Signed-off-by: bamsumit <bam_sumit@hotmail.com>
Signed-off-by: bamsumit <bam_sumit@hotmail.com>
Signed-off-by: bamsumit <bam_sumit@hotmail.com>
Signed-off-by: bamsumit <bam_sumit@hotmail.com>
Signed-off-by: bamsumit <bam_sumit@hotmail.com>
Signed-off-by: bamsumit <bam_sumit@hotmail.com>
Signed-off-by: bamsumit <bam_sumit@hotmail.com>
Signed-off-by: bamsumit <bam_sumit@hotmail.com>
Signed-off-by: bamsumit <bam_sumit@hotmail.com>
Signed-off-by: bamsumit <bam_sumit@hotmail.com>
Signed-off-by: bamsumit <bam_sumit@hotmail.com>
Signed-off-by: bamsumit <bam_sumit@hotmail.com>
Signed-off-by: bamsumit <bam_sumit@hotmail.com>
Signed-off-by: bamsumit <bam_sumit@hotmail.com>
Signed-off-by: bamsumit <bam_sumit@hotmail.com>
Signed-off-by: bamsumit <bam_sumit@hotmail.com>
@bamsumit bamsumit merged commit c12d553 into lava-nc:main Mar 3, 2023
@bamsumit bamsumit deleted the persistent_delay branch March 3, 2023 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slayer blocks don't work in persistent mode when executed one time step at a time
2 participants