Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First release #5

Merged
merged 28 commits into from Nov 13, 2021
Merged

First release #5

merged 28 commits into from Nov 13, 2021

Conversation

bamsumit
Copy link
Contributor

@bamsumit bamsumit commented Nov 8, 2021

Lava-dl slayer and bootstrap merge

@bamsumit bamsumit requested a review from mgkwill November 8, 2021 23:08
Copy link
Contributor

@awintel awintel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good... just some minor language issues...

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
lava/lib/dl/bootstrap/README.md Outdated Show resolved Hide resolved
lava/lib/dl/bootstrap/README.md Outdated Show resolved Hide resolved
@awintel awintel requested a review from gorchard November 8, 2021 23:27
README.md Outdated Show resolved Hide resolved
lava/lib/dl/bootstrap/README.md Outdated Show resolved Hide resolved
lava/lib/dl/bootstrap/README.md Outdated Show resolved Hide resolved
lava/lib/dl/bootstrap/README.md Outdated Show resolved Hide resolved
lava/lib/dl/bootstrap/README.md Outdated Show resolved Hide resolved
lava/lib/dl/slayer/README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@bamsumit
Copy link
Contributor Author

bamsumit commented Nov 9, 2021

Updated readmes with suggestions from @awintel and @gorchard

Thanks

Copy link
Contributor

@mgkwill mgkwill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@awintel awintel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. Just some minor things that you can probably address easily.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@mgkwill mgkwill merged commit f59c770 into lava-nc:main Nov 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants