Closes #17: Implementation of operations to support relational networks #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mathis Richter <mathis.richter@intel.com>
Signed-off-by: Mathis Richter <mathis.richter@intel.com>
Also refactored a function in shape_handlers.py to reduce code duplication. Signed-off-by: Mathis Richter <mathis.richter@intel.com>
Signed-off-by: Mathis Richter <mathis.richter@intel.com>
…ler. Also renamed 'ReduceDiagonal' to 'ReduceAlongDiagonal' as well as renaming its shape handler. Signed-off-by: Mathis Richter <mathis.richter@intel.com>
…pe handler. Signed-off-by: Mathis Richter <mathis.richter@intel.com>
…lip', 'ReduceAlongDiagonal', and 'ExpandAlongDiagonal'. Signed-off-by: Mathis Richter <mathis.richter@intel.com>
Signed-off-by: Mathis Richter <mathis.richter@intel.com>
Signed-off-by: Mathis Richter <mathis.richter@intel.com>
Signed-off-by: Mathis Richter <mathis.richter@intel.com>
bamsumit
approved these changes
Jan 25, 2022
joyeshmishra
approved these changes
Jan 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support to build relational networks:
All unit tests should pass but the new Jupyter tutorial does not run through because of a bug in Lava 0.2.0 that has since been fixed.
@mgkwill Should I include the changes to make lava-dnf dependent on the Lava tip in this PR or should I do this in a separate PR?