Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Sparse instead of Dense for Connections #67

Merged
merged 16 commits into from
Aug 23, 2023
Merged

Conversation

SveaMeyer13
Copy link
Contributor

@SveaMeyer13 SveaMeyer13 commented Aug 14, 2023

** Tests are failing since we need to merge corresponding changes in Lava first**
Objective of pull request: Use Sparse connectivity in the connect function by default. Allow the User to specify a different connectivity.

Pull request checklist

Your PR fulfills the following requirements:

  • Issue created that explains the change and why it's needed
  • Tests are part of the PR (for bug fixes / features)
  • Docs reviewed and added / updated if needed (for bug fixes / features)
  • PR conforms to Coding Conventions
  • PR applys BSD 3-clause or LGPL2.1+ Licenses to all code files
  • Lint (pyb) passes locally
  • Build tests (pyb -E unit) or (python -m unittest) passes locally

Pull request type

Please check your PR type:

  • Bugfix
  • [x ] Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation changes
  • Other (please describe):

What is the current behavior?

Connections are Dense by default, they cannot be changed by the user.

What is the new behavior?

Connections are Sparse by default, they can be changed by the user.

Does this introduce a breaking change?

  • Yes
  • [x ] No

@SveaMeyer13 SveaMeyer13 marked this pull request as ready for review August 14, 2023 10:25
Copy link
Contributor

@mathisrichter mathisrichter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor changes - looks good overall.

src/lava/lib/dnf/connect/connect.py Outdated Show resolved Hide resolved
src/lava/lib/dnf/connect/connect.py Outdated Show resolved Hide resolved
src/lava/lib/dnf/connect/connect.py Outdated Show resolved Hide resolved
src/lava/lib/dnf/connect/connect.py Outdated Show resolved Hide resolved
src/lava/lib/dnf/connect/connect.py Outdated Show resolved Hide resolved
tests/lava/lib/dnf/connect/test_connect.py Outdated Show resolved Hide resolved
tests/lava/lib/dnf/connect/test_connect.py Outdated Show resolved Hide resolved
tests/lava/lib/dnf/connect/test_connect.py Outdated Show resolved Hide resolved
tests/lava/lib/dnf/connect/test_connect.py Outdated Show resolved Hide resolved
tests/lava/lib/dnf/connect/test_connect.py Outdated Show resolved Hide resolved
src/lava/lib/dnf/connect/connect.py Show resolved Hide resolved
src/lava/lib/dnf/connect/connect.py Show resolved Hide resolved
tests/lava/lib/dnf/connect/test_connect.py Outdated Show resolved Hide resolved
Copy link

@gkarray gkarray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

src/lava/lib/dnf/connect/connect.py Outdated Show resolved Hide resolved
src/lava/lib/dnf/connect/connect.py Outdated Show resolved Hide resolved
@mathisrichter
Copy link
Contributor

Please check whether you can reduce the code duplication that Codacy is pointing out.

@PhilippPlank PhilippPlank merged commit 6da459b into main Aug 23, 2023
5 checks passed
@PhilippPlank PhilippPlank deleted the enable_sparse branch August 23, 2023 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants