Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing __init__.py from lava/lib to avoid module clash across lava libraries #12

Merged
merged 1 commit into from
Nov 15, 2021

Conversation

bamsumit
Copy link
Contributor

Removing init.py from lava/lib to avoid module clash across lava libraries and let namespace search take care of it.

Copy link
Contributor

@awintel awintel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@awintel
Copy link
Contributor

awintel commented Nov 15, 2021

Was there an issue with the release @bamsumit ? Should we rerelease, @bamsumit , @mgkwill ?

@bamsumit
Copy link
Contributor Author

bamsumit commented Nov 15, 2021

Yeah. Basically one cannot use lava-dl and lava-optimization together. The user can import the first optimization if it's in the python path.

@mgkwill mgkwill merged commit e428040 into lava-nc:main Nov 15, 2021
@bamsumit
Copy link
Contributor Author

@mathisrichter tagging you for lava-dnf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants