Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable tracking of cost value through runtime and retrieval as raw data and plot. #177

Merged
merged 12 commits into from
Feb 21, 2023
Merged

Enable tracking of cost value through runtime and retrieval as raw data and plot. #177

merged 12 commits into from
Feb 21, 2023

Conversation

GaboFGuerra
Copy link
Collaborator

@GaboFGuerra GaboFGuerra commented Feb 1, 2023 •
edited by AlessandroPierro

Solves issue #158

Objective of pull request: enable cost tracking through time

Pull request checklist

Your PR fulfills the following requirements:

  • Issue created that explains the change and why it's needed
  • Tests are part of the PR (for bug fixes / features)
  • Docs reviewed and added / updated if needed (for bug fixes / features)
  • PR conforms to Coding Conventions
  • PR applys BSD 3-clause or LGPL2.1+ Licenses to all code files
  • Lint (pyb) passes locally
  • Build tests (pyb -E unit) or (python -m unittest) passes locally

Pull request type

Please check your PR type:

  • Feature

What is the new behavior?

  • The SolverConfig now allows the user to request the cost probing through the probe_cost flag.
  • The SolverReport now contains the cost timeseries in the cost_timeseries property (if requested)

Does this introduce a breaking change?

  • No

@GaboFGuerra
Expose cost from CostIntegrator on the OptimizationSolver.
c9d5a13 
Signed-off-by: GaboFGuerra <gabriel.fonseca.guerra@intel.com>
@GaboFGuerra
Enable cost tracking on the OptimizationSolver.
ec3c065 
Signed-off-by: GaboFGuerra <gabriel.fonseca.guerra@intel.com>
@AlessandroPierro AlessandroPierro linked an issue Feb 1, 2023 that may be closed by this pull request
Track cost value through time and retrieve as raw data and plot. #158
Closed
4 tasks
@AlessandroPierro AlessandroPierro added the 1-feature New feature or request label Feb 1, 2023
@AlessandroPierro AlessandroPierro self-assigned this Feb 21, 2023
phstratmann
phstratmann reviewed Feb 21, 2023
View reviewed changes
Copy link
Contributor

@phstratmann phstratmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left one comment. In addition, I would suggest to delete the png, we should avoid binary files in a git repo.

phstratmann
phstratmann approved these changes Feb 21, 2023
View reviewed changes
Copy link
Contributor

@phstratmann phstratmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As always, great work. Thanks!

@AlessandroPierro AlessandroPierro merged commit e162ddc into main Feb 21, 2023
@AlessandroPierro AlessandroPierro deleted the cost_tracking branch February 21, 2023 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phstratmann phstratmann phstratmann approved these changes

@ashishrao7 ashishrao7 Awaiting requested review from ashishrao7

Assignees

@AlessandroPierro AlessandroPierro

Labels
1-feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Track cost value through time and retrieve as raw data and plot.
3 participants
@GaboFGuerra @phstratmann @AlessandroPierro