Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update SolverTuner behaviour with hyperparameters passed through SolverConfig #180

Merged
merged 1 commit into from
Feb 10, 2023
Merged

Update SolverTuner behaviour with hyperparameters passed through SolverConfig #180

merged 1 commit into from
Feb 10, 2023

Conversation

AlessandroPierro
Copy link
Collaborator

@AlessandroPierro AlessandroPierro commented Feb 10, 2023 •
edited

Objective of pull request: make SolverTuner use the hyperparameters

Pull request checklist

Your PR fulfills the following requirements:

Pull request type

Please check your PR type:

  • Feature

What is the current behavior?

  • Hyperparameters passed through the SolverConfig to the SolverTuner that are not subject to tuning are discarded

What is the new behavior?

  • Hyperparameters passed through the SolverConfig to the SolverTuner that are not subject to tuning are used. This is useful, for example, to set the neuron model to be used, and in general to set default hyperparameters that don't need tuning.

Does this introduce a breaking change?

  • No

@AlessandroPierro AlessandroPierro self-assigned this Feb 10, 2023
@AlessandroPierro AlessandroPierro marked this pull request as ready for review February 10, 2023 18:32
GaboFGuerra
GaboFGuerra approved these changes Feb 10, 2023
View reviewed changes
Copy link
Collaborator

@GaboFGuerra GaboFGuerra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@AlessandroPierro AlessandroPierro merged commit a0d9c4b into main Feb 10, 2023
@AlessandroPierro AlessandroPierro deleted the tuner-default branch February 10, 2023 18:39
@GaboFGuerra GaboFGuerra added this to the lava-optimization 0.3.0 milestone Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GaboFGuerra GaboFGuerra GaboFGuerra approved these changes

Assignees

@AlessandroPierro AlessandroPierro

Labels
1-feature New feature or request 2-important/not-urgent
Projects
None yet
Milestone
lava-optimization 0.3.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AlessandroPierro @GaboFGuerra