Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update API to enable Simulated Annealing on NEBM model #187

Merged
merged 12 commits into from
Mar 7, 2023
Merged

Update API to enable Simulated Annealing on NEBM model #187

merged 12 commits into from
Mar 7, 2023

Conversation

AlessandroPierro
Copy link
Collaborator

@AlessandroPierro AlessandroPierro commented Feb 27, 2023 •
edited

Issue Number: #174

Objective of pull request:

Pull request checklist

Your PR fulfills the following requirements:

  • Issue created that explains the change and why it's needed
  • Tests are part of the PR (for bug fixes / features)
  • Docs reviewed and added / updated if needed (for bug fixes / features)
  • PR conforms to Coding Conventions
  • PR applys BSD 3-clause or LGPL2.1+ Licenses to all code files
  • Lint (pyb) passes locally
  • Build tests (pyb -E unit) or (python -m unittest) passes locally

Pull request type

Please check your PR type:

  • Feature
  • Refactoring (no functional changes, no api changes)

What is the current behavior?

What is the new behavior?

Does this introduce a breaking change?

  • Yes

@AlessandroPierro AlessandroPierro self-assigned this Feb 27, 2023
@AlessandroPierro AlessandroPierro added the 1-feature New feature or request label Feb 27, 2023
@AlessandroPierro AlessandroPierro linked an issue Feb 27, 2023 that may be closed by this pull request
Loihi 2 OptimizationSolver with annealing schedule for solving QUBO problems #174
Closed
9 tasks
@AlessandroPierro AlessandroPierro changed the title Sa Update API to enable Simulated Annealing on NEBM model Feb 27, 2023
@AlessandroPierro AlessandroPierro marked this pull request as ready for review March 6, 2023 17:04
@AlessandroPierro AlessandroPierro requested review from phstratmann and removed request for GaboFGuerra March 6, 2023 17:11
phstratmann
phstratmann approved these changes Mar 7, 2023
View reviewed changes
Copy link
Contributor

@phstratmann phstratmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only minor changes. Please address them and then feel free to merge.

Great work!

@AlessandroPierro AlessandroPierro merged commit 4b9814e into main Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phstratmann phstratmann phstratmann approved these changes

Assignees

@AlessandroPierro AlessandroPierro

Labels
1-feature New feature or request
Projects
None yet
Milestone
lava-optimization 0.3.0
Development

Successfully merging this pull request may close these issues.

Loihi 2 OptimizationSolver with annealing schedule for solving QUBO problems
2 participants
@AlessandroPierro @phstratmann