Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Track cost instead of minimum cost when user sets probe_cost = True on SolverConfig. #194

Merged
merged 7 commits into from
Mar 9, 2023
Merged

Track cost instead of minimum cost when user sets probe_cost = True on SolverConfig. #194

merged 7 commits into from
Mar 9, 2023

Conversation

GaboFGuerra
Copy link
Collaborator

@GaboFGuerra GaboFGuerra commented Mar 8, 2023 •
edited by AlessandroPierro

Issue Number:

Objective of pull request:

Pull request checklist

Your PR fulfills the following requirements:

  • Issue created that explains the change and why it's needed
  • Tests are part of the PR (for bug fixes / features)
  • Docs reviewed and added / updated if needed (for bug fixes / features)
  • PR conforms to Coding Conventions
  • PR applys BSD 3-clause or LGPL2.1+ Licenses to all code files
  • Lint (pyb) passes locally
  • Build tests (pyb -E unit) or (python -m unittest) passes locally

Pull request type

Please check your PR type:

  • Bugfix

What is the current behavior?

What is the new behavior?

Does this introduce a breaking change?

  • Yes

@GaboFGuerra
Expose cost from CostIntegrator on the OptimizationSolver.
c9d5a13 
Signed-off-by: GaboFGuerra <gabriel.fonseca.guerra@intel.com>
@GaboFGuerra
Enable cost tracking on the OptimizationSolver.
ec3c065 
Signed-off-by: GaboFGuerra <gabriel.fonseca.guerra@intel.com>
@GaboFGuerra
Merge branch 'main' of https://github.com/lava-nc/lava-optimization
5d1a35c
@GaboFGuerra
Merge local and remote mains which diverged.
db392e5 
Signed-off-by: GaboFGuerra <gabriel.fonseca.guerra@intel.com>
@GaboFGuerra
Remove obsolete code.
8cf27f5 
Signed-off-by: GaboFGuerra <gabriel.fonseca.guerra@intel.com>
@GaboFGuerra
Track cost instead of minimum cost when user sets probe_cost=True.
7f57469 
Signed-off-by: GaboFGuerra <gabriel.fonseca.guerra@intel.com>
@GaboFGuerra GaboFGuerra self-assigned this Mar 8, 2023
@GaboFGuerra
Solve linting issues.
61c34da 
Signed-off-by: GaboFGuerra <gabriel.fonseca.guerra@intel.com>
AlessandroPierro
AlessandroPierro approved these changes Mar 9, 2023
View reviewed changes
Copy link
Collaborator

@AlessandroPierro AlessandroPierro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

I only left a comment on the naming of variables, but apart from that feel free to merge.

@GaboFGuerra GaboFGuerra merged commit a3e5b1e into main Mar 9, 2023
@AlessandroPierro AlessandroPierro deleted the c_track branch July 6, 2023 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlessandroPierro AlessandroPierro AlessandroPierro approved these changes

Assignees

@GaboFGuerra GaboFGuerra

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@GaboFGuerra @AlessandroPierro