Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix refract_counter init in NEBM/NEBMSA #223

Merged
merged 1 commit into from
May 8, 2023
Merged

Fix refract_counter init in NEBM/NEBMSA #223

merged 1 commit into from
May 8, 2023

Conversation

AlessandroPierro
Copy link
Collaborator

Objective of pull request: fix initialization of refract_counter to match expected behaviour

Pull request checklist

Your PR fulfills the following requirements:

  • Issue created that explains the change and why it's needed
  • Tests are part of the PR (for bug fixes / features)
  • Docs reviewed and added / updated if needed (for bug fixes / features)
  • PR conforms to Coding Conventions
  • PR applys BSD 3-clause or LGPL2.1+ Licenses to all code files
  • Lint (pyb) passes locally
  • Build tests (pyb -E unit) or (python -m unittest) passes locally

Pull request type

Please check your PR type:

  • Bugfix

What is the current behavior?

  • refract_counter was initialized to 0 in NEBM and NEBMSA processes, resulting in the model not entering in refractory period after the first spike

What is the new behavior?

-refract_counter is correctly initialized, based on the value of refract and refract_scaling

Does this introduce a breaking change?

  • No

@AlessandroPierro AlessandroPierro added the 1-bug Something isn't working label May 8, 2023
@AlessandroPierro AlessandroPierro self-assigned this May 8, 2023
@AlessandroPierro AlessandroPierro marked this pull request as ready for review May 8, 2023 15:28
GaboFGuerra
GaboFGuerra approved these changes May 8, 2023
View reviewed changes
Copy link
Collaborator

@GaboFGuerra GaboFGuerra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Thanks Alessandro

@AlessandroPierro AlessandroPierro merged commit 58e26e5 into main May 8, 2023
3 checks passed
@AlessandroPierro AlessandroPierro deleted the bugfix-init-refract branch May 8, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GaboFGuerra GaboFGuerra GaboFGuerra approved these changes

Assignees

@AlessandroPierro AlessandroPierro

Labels
1-bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AlessandroPierro @GaboFGuerra