Add Clustering and TSP apps #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Risbud, Sumedh <sumedh.risbud@intel.com>
Signed-off-by: Risbud, Sumedh <sumedh.risbud@intel.com>
Signed-off-by: Risbud, Sumedh <sumedh.risbud@intel.com>
Signed-off-by: Risbud, Sumedh <sumedh.risbud@intel.com>
…ated `best_solution` in read_gate Signed-off-by: Risbud, Sumedh <sumedh.risbud@intel.com>
Signed-off-by: Risbud, Sumedh <sumedh.risbud@intel.com>
for a) clustering b) tsp. TODO: Add Typing code
Signed-off-by: Risbud, Sumedh <sumedh.risbud@intel.com>
Signed-off-by: Risbud, Sumedh <sumedh.risbud@intel.com>
Made changes to TSP API only. Further work needed on TSP logic
Encoding is now accurate
(with test)
Signed-off-by: Risbud, Sumedh <sumedh.risbud@intel.com>
Signed-off-by: Risbud, Sumedh <sumedh.risbud@intel.com>
Signed-off-by: Risbud, Sumedh <sumedh.risbud@intel.com>
Signed-off-by: Risbud, Sumedh <sumedh.risbud@intel.com>
…ated `best_solution` in read_gate Signed-off-by: Risbud, Sumedh <sumedh.risbud@intel.com>
for a) clustering b) tsp. TODO: Add Typing code
Signed-off-by: Risbud, Sumedh <sumedh.risbud@intel.com>
Signed-off-by: Risbud, Sumedh <sumedh.risbud@intel.com>
Signed-off-by: Risbud, Sumedh <sumedh.risbud@intel.com>
Signed-off-by: Risbud, Sumedh <sumedh.risbud@intel.com>
…ated `best_solution` in read_gate Signed-off-by: Risbud, Sumedh <sumedh.risbud@intel.com>
Made changes to TSP API only. Further work needed on TSP logic
Encoding is now accurate
Signed-off-by: Risbud, Sumedh <sumedh.risbud@intel.com>
…ests Signed-off-by: Risbud, Sumedh <sumedh.risbud@intel.com>
Signed-off-by: Risbud, Sumedh <sumedh.risbud@intel.com>
Signed-off-by: Risbud, Sumedh <sumedh.risbud@intel.com>
Signed-off-by: Risbud, Sumedh <sumedh.risbud@intel.com>
srrisbud
requested review from
mathisrichter,
ashishrao7,
awintel,
drager-intel,
GaboFGuerra and
phstratmann
Signed-off-by: Risbud, Sumedh <sumedh.risbud@intel.com>
Signed-off-by: Risbud, Sumedh <sumedh.risbud@intel.com>
Signed-off-by: Risbud, Sumedh <sumedh.risbud@intel.com>
ashishrao7
reviewed
Oct 23, 2023
There was a problem hiding this comment.
Thanks for the PR. It looks mostly good. I am not sure whether a brief one-liner would be helpful as docstrings for classes in the tests. Since these are applications built on top of a lot of work, it can tend to be very hard to understand. The naming is generally self-explanatory but doc-strings might make it easier for the user to understand what's going on.
ashishrao7
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective of pull request: To add new apps that solve clustering and travelling salesman problems using the Lava QUBO solver.
Pull request checklist
Your PR fulfills the following requirements:
pyb) passes locallypyb -E unit) or (python -m unittest) passes locallyPull request type
Please check your PR type:
Does this introduce a breaking change?