Update OptiizationSolver with new profiler API to enable execution time measurement on Loihi2 #61

GaboFGuerra · 2022-10-20T08:53:53Z

Objective of pull request: Update OptiizationSolver with new profiler API to enable execution time measurement on Loihi2

Pull request checklist

Your PR fulfills the following requirements:

Tests are part of the PR (for bug fixes / features)
Docs reviewed and added / updated if needed (for bug fixes / features)
PR conforms to Coding Conventions
PR applys BSD 3-clause or LGPL2.1+ Licenses to all code files
Lint (pyb) passes locally
Build tests (pyb -E unit) or (python -m unittest) passes locally

Pull request type

Please check your PR type:

Feature

What is the new behavior?

Does this introduce a breaking change?

No

Signed-off-by: GaboFGuerra <gabriel.fonseca.guerra@intel.com>

Add first tests for ProtytypeOfSolverBenchmarker

Add tests for ProtytypeOfSolverBenchmarker

Add SolverBenchmarker and tests

Add docstrings to SolverBenchmarker

Solver benchmarker

Signed-off-by: GaboFGuerra <gabriel.fonseca.guerra@intel.com>

…me property Signed-off-by: GaboFGuerra <gabriel.fonseca.guerra@intel.com>

Signed-off-by: GaboFGuerra <gabriel.fonseca.guerra@intel.com>

Address PR feedback

src/lava/lib/optimization/solvers/generic/solver.py

Solver benchmarker

Solver benchmarker with measurement methods

src/lava/lib/optimization/utils/solver_benchmarker.py

Bugfix after main merge

Solver benchmarker

GaboFGuerra added 3 commits October 20, 2022 10:27

Add prototype for SolverBenchmarker as reference to start TDD.

81453a6

Signed-off-by: GaboFGuerra <gabriel.fonseca.guerra@intel.com>

Add documentation to prototype for SolverBenchmarker.

649e2a9

Initiate test file for TDD of SolverBenchmarker.

4100892

Signed-off-by: GaboFGuerra <gabriel.fonseca.guerra@intel.com>

GaboFGuerra assigned GaboFGuerra, calixphd and AlessandroPierro Oct 20, 2022

AlessandroPierro and others added 8 commits October 20, 2022 13:08

Add first tests for ProtytypeOfSolverBenchmarker

02d41c7

Merge pull request #62 from AlessandroPierro/solver_benchmarker

3544e53

Add first tests for ProtytypeOfSolverBenchmarker

Add tests for ProtytypeOfSolverBenchmarker

79cd01b

Merge pull request #63 from AlessandroPierro/solver_benchmarker

480c48d

Add tests for ProtytypeOfSolverBenchmarker

Add SolverBenchmarker and tests

4464f03

Merge pull request #64 from AlessandroPierro/solver_benchmarker

8cc9ec8

Add SolverBenchmarker and tests

Add docstrings to SolverBenchmarker

dbea5a7

Merge pull request #65 from AlessandroPierro/solver_benchmarker

78f7a26

Add docstrings to SolverBenchmarker

GaboFGuerra requested review from ashishrao7 and phstratmann October 21, 2022 16:05

GaboFGuerra marked this pull request as ready for review October 21, 2022 16:06

AlessandroPierro added the 1-feature New feature or request label Oct 23, 2022

AlessandroPierro and others added 11 commits October 24, 2022 00:41

Refactor SolverBenchmarker

441b994

Merge branch 'lava-nc:solver_benchmarker' into solver_benchmarker

d42b3cf

Merge pull request #67 from AlessandroPierro/solver_benchmarker

099e045

Solver benchmarker

Refactor SolverBenchmarker

3df659b

Merge branch 'lava-nc:solver_benchmarker' into solver_benchmarker

b6dd8dd

Merge pull request #68 from AlessandroPierro/solver_benchmarker

839f15e

Solver benchmarker

Delete poetry.lock

f46f340

Add compute_cost method to QUBO problem.

6642dcf

Signed-off-by: GaboFGuerra <gabriel.fonseca.guerra@intel.com>

Compose SolverBenchmarker into OptimizationSolver and add measured_ti…

1e79e39

…me property Signed-off-by: GaboFGuerra <gabriel.fonseca.guerra@intel.com>

Bypass SolverBenchmarker dependency on access to lava-on-loihi.

2d02848

Signed-off-by: GaboFGuerra <gabriel.fonseca.guerra@intel.com>

Solve linting issues.

b75f3f9

Signed-off-by: GaboFGuerra <gabriel.fonseca.guerra@intel.com>

GaboFGuerra changed the title ~~Add SolverBenchmarker to setup power and time measurements and get results.~~ Add SolverBenchmarker to setup power and time measurements and get results on OptimizationSolver. Oct 26, 2022

AlessandroPierro added 2 commits October 27, 2022 11:37

Address PR feedback

8071b19

Merge pull request #97 from AlessandroPierro/solver_benchmarker

f56749a

Address PR feedback

AlessandroPierro self-requested a review October 27, 2022 09:46

AlessandroPierro approved these changes Oct 27, 2022

View reviewed changes

phstratmann reviewed Oct 27, 2022

View reviewed changes

src/lava/lib/optimization/solvers/generic/solver.py Outdated Show resolved Hide resolved

AlessandroPierro and others added 14 commits October 27, 2022 13:13

Address PR feedback

2c4e1cb

Fix matrix type in solver tests

0fd6152

Merge branch 'lava-nc:solver_benchmarker' into solver_benchmarker

d12d2b3

Merge pull request #98 from AlessandroPierro/solver_benchmarker

470c4c8

Solver benchmarker

Merge branch 'main' into solver_benchmarker

cce0765

Add measure solving energy/time

49a0432

add updates to run_time config

3fd0cdc

throwAdd error message when Loihi2 is not available

9eefee1

Refactored run_time and energy config

447580b

Remove linting issues

4ca3494

Resolve linting issues

8badb96

Remove linting issues

f110e44

resolve linting problem

4310553

Merge pull request #102 from calixphd/solver_benchmarker

260dd4b

Solver benchmarker with measurement methods

PhilippPlank reviewed Oct 28, 2022

View reviewed changes

src/lava/lib/optimization/utils/solver_benchmarker.py Outdated Show resolved Hide resolved

AlessandroPierro added 7 commits October 28, 2022 11:50

Merge main and resolve conflicts

6e166aa

Add poetry.lock

e5c4783

Bugfix after main merge

6e17446

Merge pull request #108 from AlessandroPierro/solver_benchmarker

1c911a0

Bugfix after main merge

Integrate profiler API in OptimizationSolver

ace00cf

Merge branch 'lava-nc:solver_benchmarker' into solver_benchmarker

f8e2887

Merge pull request #109 from AlessandroPierro/solver_benchmarker

40055e9

Solver benchmarker

AlessandroPierro changed the title ~~Add SolverBenchmarker to setup power and time measurements and get results on OptimizationSolver.~~ Update OptiizationSolver with new profiler API to enable execution time measurement on Loihi2 Oct 28, 2022

AlessandroPierro merged commit 086998e into main Oct 28, 2022

AlessandroPierro deleted the solver_benchmarker branch October 28, 2022 11:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update OptiizationSolver with new profiler API to enable execution time measurement on Loihi2 #61

Update OptiizationSolver with new profiler API to enable execution time measurement on Loihi2 #61

GaboFGuerra commented Oct 20, 2022 •

edited by AlessandroPierro

Loading

Update OptiizationSolver with new profiler API to enable execution time measurement on Loihi2 #61

Update OptiizationSolver with new profiler API to enable execution time measurement on Loihi2 #61

Conversation

GaboFGuerra commented Oct 20, 2022 • edited by AlessandroPierro Loading

Pull request checklist

Pull request type

What is the new behavior?

Does this introduce a breaking change?

GaboFGuerra commented Oct 20, 2022 •

edited by AlessandroPierro

Loading