Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SolverTuner to support hyperparameters search and track steps to solution across SolverProcess. #66

Merged
merged 62 commits into from
Oct 28, 2022
Merged

Add SolverTuner to support hyperparameters search and track steps to solution across SolverProcess. #66

merged 62 commits into from
Oct 28, 2022

Conversation

GaboFGuerra
Copy link
Collaborator

@GaboFGuerra GaboFGuerra commented Oct 24, 2022 •
edited by AlessandroPierro

Issue Number:

Objective of pull request: add the SolverTuner utility class to provide hyperparameters grid search for OptimizationProblem

Pull request checklist

Your PR fulfills the following requirements:

Pull request type

Please check your PR type:

  • Feature

What is the new behavior?

  • This PR introduces SolverTuner, an utility class that enables hyperparameters grid search for all problems inheriting from OptimizationProblem.

Does this introduce a breaking change?

  • No

@GaboFGuerra
Add hyperparameters property with default dict to OptimizationSolver.
4e7ed04 
Signed-off-by: GaboFGuerra <gabriel.fonseca.guerra@intel.com>
@GaboFGuerra
Add prototype for SolverTunner.
ac994c5 
Signed-off-by: GaboFGuerra <gabriel.fonseca.guerra@intel.com>
@GaboFGuerra
Start SolverTunner unit test suite.
54fdeef 
Signed-off-by: GaboFGuerra <gabriel.fonseca.guerra@intel.com>
@AlessandroPierro AlessandroPierro changed the title Add SolverTunner initially supporting grid search for hyperparameters. Add SolverTuner initially supporting grid search for hyperparameters. Oct 24, 2022
@AlessandroPierro AlessandroPierro added the 1-feature New feature or request label Oct 24, 2022
@AlessandroPierro AlessandroPierro changed the title Add SolverTuner initially supporting grid search for hyperparameters. Add SolverTuner to support hyperparameters grid search for QUBO problems Oct 24, 2022
@AlessandroPierro AlessandroPierro changed the title Add SolverTuner to support hyperparameters grid search for QUBO problems Add SolverTuner to support hyperparameters search for QUBO problems Oct 24, 2022
@AlessandroPierro AlessandroPierro changed the title Add SolverTuner to support hyperparameters search for QUBO problems Add SolverTuner to support hyperparameters search for QUBO Oct 24, 2022
@AlessandroPierro AlessandroPierro changed the title Add SolverTuner to support hyperparameters search for QUBO Add SolverTuner to support hyperparameters search Oct 24, 2022
@GaboFGuerra GaboFGuerra marked this pull request as ready for review October 26, 2022 11:17
GaboFGuerra and others added 8 commits October 26, 2022 13:45
@GaboFGuerra
Update initial value for init_value and init_state.
e4b0940 
Signed-off-by: GaboFGuerra <gabriel.fonseca.guerra@intel.com>
@GaboFGuerra
Add last_run_report property and its updating mechanism.
fedcf27 
Signed-off-by: GaboFGuerra <gabriel.fonseca.guerra@intel.com>
@AlessandroPierro
Switch to random search in SolverTuner
f7253dc
@GaboFGuerra
Perform method extraction and clean up on solve method.
f10cf74 
Signed-off-by: GaboFGuerra <gabriel.fonseca.guerra@intel.com>
@GaboFGuerra
Add solution_step variable and acknowledgement port to SolutionReadout.
6e9223a 
Signed-off-by: GaboFGuerra <gabriel.fonseca.guerra@intel.com>
@GaboFGuerra
Add solution_step to MacroStateReader.
f0a63fc 
Signed-off-by: GaboFGuerra <gabriel.fonseca.guerra@intel.com>
@GaboFGuerra
Point min_cost of MacroStateReader to the right variable.
1b5bb2e 
Signed-off-by: GaboFGuerra <gabriel.fonseca.guerra@intel.com>
@GaboFGuerra
Add solution_step as a SolverProcess variable, include alias and conn…
3446269 
…ect acknowledgement ports.

Signed-off-by: GaboFGuerra <gabriel.fonseca.guerra@intel.com>
@GaboFGuerra GaboFGuerra changed the title Add SolverTuner to support hyperparameters search Add SolverTuner to support hyperparameters search and track steps to solution across SolverProcess. Oct 26, 2022
@AlessandroPierro AlessandroPierro requested review from AlessandroPierro and removed request for srrisbud and PhilippPlank October 27, 2022 14:27
AlessandroPierro and others added 13 commits October 27, 2022 19:23
@AlessandroPierro
Merge branch 'main' into solver_tunner
ea6baaf
@GaboFGuerra
Skip SolverTunner tests to narrow down bug on CI.
972dace 
Signed-off-by: GaboFGuerra <gabriel.fonseca.guerra@intel.com>
@GaboFGuerra
Merge branch 'main' into solver_tunner
434b6b5
@GaboFGuerra
Solve linting issue.
dfc2b27 
Signed-off-by: GaboFGuerra <gabriel.fonseca.guerra@intel.com>
@GaboFGuerra
Merge branch 'solver_tunner' of https://github.com/lava-nc/lava-optim…
e153397 
…ization into solver_tunner
@GaboFGuerra
Revert test skip.
76b1aa7 
Signed-off-by: GaboFGuerra <gabriel.fonseca.guerra@intel.com>
@GaboFGuerra
Apply changes reverted during one of the mergings.
2b4bdf2 
Signed-off-by: GaboFGuerra <gabriel.fonseca.guerra@intel.com>
@GaboFGuerra
Merge branch 'main' into solver_tunner
c34d14b
@GaboFGuerra
Merge branch 'main' into solver_tunner
b382744
@GaboFGuerra
Remove method making class abstract.
681e47a 
Signed-off-by: GaboFGuerra <gabriel.fonseca.guerra@intel.com>
@GaboFGuerra
Don't overwrite main.
3be4bf8 
Signed-off-by: GaboFGuerra <gabriel.fonseca.guerra@intel.com>
@AlessandroPierro
Bugfig in OptimizationSolver
8c2d393
@AlessandroPierro
Merge pull request #107 from AlessandroPierro/solver_tuner
9b19c31 
Bugfig in OptimizationSolver
@GaboFGuerra GaboFGuerra merged commit 24baae5 into main Oct 28, 2022
@AlessandroPierro AlessandroPierro deleted the solver_tunner branch October 31, 2022 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phstratmann phstratmann phstratmann left review comments

@AlessandroPierro AlessandroPierro AlessandroPierro approved these changes

Assignees

@AlessandroPierro AlessandroPierro

@GaboFGuerra GaboFGuerra

@calixphd calixphd

Labels
1-feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@GaboFGuerra @AlessandroPierro @phstratmann @calixphd