-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relocate optimization specific processes to lava-optimization and out of lava/proc #83
Conversation
Signed-off-by: GaboFGuerra <gabriel.fonseca.guerra@intel.com>
Signed-off-by: GaboFGuerra <gabriel.fonseca.guerra@intel.com>
…tance. Signed-off-by: GaboFGuerra <gabriel.fonseca.guerra@intel.com>
Signed-off-by: GaboFGuerra <gabriel.fonseca.guerra@intel.com>
Signed-off-by: GaboFGuerra <gabriel.fonseca.guerra@intel.com>
This comment was marked as resolved.
This comment was marked as resolved.
Address linter issues
Update import paths
Tests on Scif are failing with:
|
Signed-off-by: GaboFGuerra <gabriel.fonseca.guerra@intel.com>
…a-optimization into relocate_optim_procs
tests/lava/lib/optimization/solvers/generic/scif/test_models.py
Outdated
Show resolved
Hide resolved
tests/lava/lib/optimization/solvers/generic/scif/test_process.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before merging, please ensure that the license headers are correct! Currently, they are wrong for the test files, see my comments.
Didn't review the code in detail, as it has been reviewed previously. Only the new places for the files.
Thanks for your great work :-)
solved |
Signed-off-by: GaboFGuerra <gabriel.fonseca.guerra@intel.com>
Objective of pull request: Relocate optimization specific processes to lava-optimization and out of lava/proc.
Pull request checklist
Your PR fulfills the following requirements:
pyb
) passes locallypyb -E unit
) or (python -m unittest
) passes locallyPull request type
Please check your PR type:
What is the current behavior?
What is the new behavior?
Does this introduce a breaking change?
Supplemental information
The import path for ReadGate, QuboScif and CostIntegrator are changed, they are not longer under lava.proc but under lava.optimization.solvers.generic.processes