Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relocate optimization specific processes to lava-optimization and out of lava/proc #83

Merged
merged 14 commits into from
Oct 26, 2022

Conversation

GaboFGuerra
Copy link
Collaborator

@GaboFGuerra GaboFGuerra commented Oct 26, 2022

Objective of pull request: Relocate optimization specific processes to lava-optimization and out of lava/proc.

Pull request checklist

Your PR fulfills the following requirements:

Pull request type

Please check your PR type:

  • Refactoring

What is the current behavior?

  • Optimization specific processes are exposed under lava/proc which is intended for generic processes.

What is the new behavior?

  • Processes specific to the optimization library have been moved under lava/lib/optimization/solvers/generic/processes.

Does this introduce a breaking change?

  • Yes

Supplemental information

The import path for ReadGate, QuboScif and CostIntegrator are changed, they are not longer under lava.proc but under lava.optimization.solvers.generic.processes

Signed-off-by: GaboFGuerra <gabriel.fonseca.guerra@intel.com>
Signed-off-by: GaboFGuerra <gabriel.fonseca.guerra@intel.com>
…tance.

Signed-off-by: GaboFGuerra <gabriel.fonseca.guerra@intel.com>
Signed-off-by: GaboFGuerra <gabriel.fonseca.guerra@intel.com>
Signed-off-by: GaboFGuerra <gabriel.fonseca.guerra@intel.com>
@AlessandroPierro

This comment was marked as resolved.

@AlessandroPierro
Copy link
Collaborator

Tests on Scif are failing with:

lava.magma.compiler.exceptions.NoProcessModelFound: No ProcessModels found that implement Process '<lava.lib.optimization.solvers.generic.scif.process.QuboScif object at 0x7ffa90c57d60>'

@phstratmann
Copy link
Contributor

Tests on Scif are failing with:

lava.magma.compiler.exceptions.NoProcessModelFound: No ProcessModels found that implement Process '<lava.lib.optimization.solvers.generic.scif.process.QuboScif object at 0x7ffa90c57d60>'

And with
image

Copy link
Contributor

@phstratmann phstratmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before merging, please ensure that the license headers are correct! Currently, they are wrong for the test files, see my comments.

Didn't review the code in detail, as it has been reviewed previously. Only the new places for the files.

Thanks for your great work :-)

@GaboFGuerra
Copy link
Collaborator Author

solved

GaboFGuerra and others added 2 commits October 26, 2022 21:34
Signed-off-by: GaboFGuerra <gabriel.fonseca.guerra@intel.com>
@GaboFGuerra GaboFGuerra merged commit 4cc3e88 into main Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants