Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of ReadVar and ResetVar IO process and bugfixes for LIF, Dense and Conv processes #156

Merged
merged 14 commits into from Feb 6, 2022

Conversation

bamsumit
Copy link
Contributor

@bamsumit bamsumit commented Jan 4, 2022

Issue Number: 155

Objective of pull request:

  • Implementation of ReadVar and ResetVar IO process
  • bugfixes for LIF, Dense and Conv processes

Pull request checklist

Your PR fulfills the following requirements:

  • Issue created that explains the change and why it's needed
  • Tests are part of the PR (for bug fixes / features)
  • Docs reviewed and added / updated if needed (for bug fixes / features)
  • PR conforms to Coding Conventions
  • PR applys BSD 3-clause or LGPL2.1+ Licenses to all code files
  • Lint (pyb) passes locally
  • Build tests (pyb -E unit) or (python -m unittest) passes locally

Pull request type

Please check your PR type:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation changes
  • Other (please describe):

What is the current behavior?

  • The feature does not exist.

What is the new behavior?

# Reset Var
ResetVar(existing_proc.var, reset_value, interval, offset)
# Read Var
read_proc = ReadVar(existing_proc.var, interval, offset)
... run network
data = read_proc.data.get()

Does this introduce a breaking change?

  • Yes
  • No

Supplemental information

@bamsumit bamsumit self-assigned this Jan 4, 2022
@bamsumit bamsumit added 1-feature New feature request 0-needs-review For all new issues labels Jan 4, 2022
Copy link
Contributor

@PhilippPlank PhilippPlank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor things to change. Please also resolve the conflict in lif/models.py

src/lava/proc/conv/models.py Outdated Show resolved Hide resolved
src/lava/proc/conv/models.py Outdated Show resolved Hide resolved
src/lava/proc/io/__init__.py Show resolved Hide resolved
src/lava/proc/io/__init__.py Outdated Show resolved Hide resolved
src/lava/proc/io/reset.py Outdated Show resolved Hide resolved
src/lava/proc/io/sink.py Outdated Show resolved Hide resolved
src/lava/proc/io/sink.py Outdated Show resolved Hide resolved
src/lava/proc/io/source.py Outdated Show resolved Hide resolved
src/lava/proc/lif/models.py Outdated Show resolved Hide resolved
tests/lava/proc/lif/test_models.py Show resolved Hide resolved
tests/lava/proc/io/test_source_sink.py Outdated Show resolved Hide resolved
src/lava/proc/io/sink.py Show resolved Hide resolved
src/lava/proc/io/reset.py Outdated Show resolved Hide resolved
Signed-off-by: bamsumit <bam_sumit@hotmail.com>
Signed-off-by: bamsumit <bam_sumit@hotmail.com>
Signed-off-by: bamsumit <bam_sumit@hotmail.com>
Signed-off-by: bamsumit <bam_sumit@hotmail.com>
Signed-off-by: bamsumit <bam_sumit@hotmail.com>
src/lava/proc/conv/models.py Outdated Show resolved Hide resolved
src/lava/proc/conv/process.py Outdated Show resolved Hide resolved
src/lava/proc/conv/process.py Outdated Show resolved Hide resolved
src/lava/proc/lif/models.py Show resolved Hide resolved
src/lava/proc/lif/process.py Outdated Show resolved Hide resolved
Signed-off-by: bamsumit <bam_sumit@hotmail.com>
Copy link
Contributor

@drager-intel drager-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still in favor of using the same (int) data type and connection process logic for binary vs graded spikes. Maybe I will run some quick tests to see if summing the binary vectors is substantially more performative than np.dot

src/lava/proc/conv/models.py Show resolved Hide resolved
src/lava/proc/dense/models.py Show resolved Hide resolved
src/lava/proc/dense/models.py Show resolved Hide resolved
@srrisbud srrisbud merged commit 32fb7ae into lava-nc:main Feb 6, 2022
@bamsumit bamsumit deleted the netx_fixes branch February 7, 2022 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-needs-review For all new issues 1-feature New feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants