Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Virtual ports between RefPorts and VarPorts #195

Merged
merged 29 commits into from Mar 2, 2022
Merged

Virtual ports between RefPorts and VarPorts #195

merged 29 commits into from Mar 2, 2022

Conversation

mathisrichter
Copy link
Contributor

Issue Number: #194

Objective of pull request: Provide support for virtual ports between RefPorts and VarPorts

Pull request checklist

Your PR fulfills the following requirements:

  • Issue created that explains the change and why it's needed
  • Tests are part of the PR (for bug fixes / features)
  • Docs reviewed and added / updated if needed (for bug fixes / features)
  • PR conforms to Coding Conventions
  • PR applys BSD 3-clause or LGPL2.1+ Licenses to all code files
  • Lint (pyb) passes locally
  • Build tests (pyb -E unit) or (python -m unittest) passes locally

Pull request type

Please check your PR type:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation changes
  • Other (please describe):

What is the current behavior?

  • Virtual ports between RefPorts and VarPorts raise an exception

What is the new behavior?

  • Virtual ports (reshape/flatten/transpose) between RefPorts and VarPorts work.

Does this introduce a breaking change?

  • Yes
  • No

Supplemental information

bamsumit and others added 25 commits January 20, 2022 16:26
@bamsumit
permute initial implementation
d3a65e7 
Signed-off-by: bamsumit <bam_sumit@hotmail.com>
@bamsumit
Tests for permute ports
58d5a14
@mathisrichter
Process property of virtual ports no longer returns None
3891c8c 
Signed-off-by: Mathis Richter <mathis.richter@intel.com>
@mathisrichter
Added initial run-unittest for flatten() from issue lava-nc#163
eba5df9 
Signed-off-by: Mathis Richter <mathis.richter@intel.com>
@mathisrichter
User-level API for TransposePort with unit tests
917a497 
Signed-off-by: Mathis Richter <mathis.richter@intel.com>
@mathisrichter
Fixed typo
0f33774 
Signed-off-by: Mathis Richter <mathis.richter@intel.com>
@mathisrichter
Unit tests for flatten() and concat_with()
1537c41 
Signed-off-by: Mathis Richter <mathis.richter@intel.com>
@mathisrichter
Unit tests for virtual ports in Processes that are executed (wip)
938b7db 
Signed-off-by: Mathis Richter <mathis.richter@intel.com>
@mathisrichter
Preliminary implementation of virtual ports between OutPort and InPor…
d0eff5a 
…t (wip)

Signed-off-by: Mathis Richter <mathis.richter@intel.com>
@mathisrichter
Merge branch 'main' of https://github.com/lava-nc/lava into permute
5076ab4 
� Conflicts:
�	src/lava/magma/compiler/compiler.py
�	src/lava/magma/core/model/py/ports.py
�	tests/lava/magma/core/model/py/test_ports.py
@mathisrichter
Fixing unit tests after merge
846c1b3 
Signed-off-by: Mathis Richter <mathis.richter@intel.com>
@bamsumit
Merge branch 'main' into permute
9bde78e
@mathisrichter
Added support for virtual ports between an OutPort and InPort of two …
effd522 
…hierarchical Processes

Signed-off-by: Mathis Richter <mathis.richter@intel.com>
@mathisrichter
Merge branch 'permute' of https://github.com/bamsumit/lava into permute
a1be80f
@mathisrichter
Clean up, exceptions, and generic unit tests for virtual port topologies
c5d0f5f 
Signed-off-by: Mathis Richter <mathis.richter@intel.com>
@mathisrichter
Fixed linter issues
abf03bd 
Signed-off-by: Mathis Richter <mathis.richter@intel.com>
@mgkwill
Merge branch 'main' into permute
c02a44a
@bamsumit
Merge branch 'main' into permute
166ec46
@mathisrichter
Raising an exception when executing ConcatPort
6ca8a51 
Signed-off-by: Mathis Richter <mathis.richter@intel.com>
@mathisrichter
Merge branch 'main' of https://github.com/lava-nc/lava into permute
9ebfc6f 
� Conflicts:
�	src/lava/magma/compiler/compiler.py
@mathisrichter
Merge branch 'permute' of https://github.com/bamsumit/lava into permute
4873eca
@mathisrichter
Merge
71d1e8b 
Signed-off-by: Mathis Richter <mathis.richter@intel.com>
@mathisrichter
Unit tests for virtual ports between OutPorts and InPorts in hierarch…
0d5b0bf 
…ical Processes.

Signed-off-by: Mathis Richter <mathis.richter@intel.com>
@mathisrichter
RefPort writing to an explicit VarPort via a virtual port.
6a15666 
Signed-off-by: Mathis Richter <mathis.richter@intel.com>
@mathisrichter
RefPort reading from an explicit VarPort via a virtual port.
9ceddb1 
Signed-off-by: Mathis Richter <mathis.richter@intel.com>
@mathisrichter mathisrichter self-assigned this Feb 28, 2022
@mathisrichter
Fixed linter error
fbf1f54 
Signed-off-by: Mathis Richter <mathis.richter@intel.com>
@mathisrichter
Unit tests for virtual ports between RefPorts and VarPorts in hierarc…
ae4debf 
…hical Processes.

Signed-off-by: Mathis Richter <mathis.richter@intel.com>
@mathisrichter
Fixed a docstring
83fd8d9 
Signed-off-by: Mathis Richter <mathis.richter@intel.com>
PhilippPlank
PhilippPlank approved these changes Mar 1, 2022
View reviewed changes
Copy link
Contributor

@PhilippPlank PhilippPlank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

src/lava/magma/core/process/ports/ports.py Show resolved Hide resolved
@mathisrichter
Added docstrings to methods get_transform_func_fwd/bwd.
eaf55ca 
Signed-off-by: Mathis Richter <mathis.richter@intel.com>
@mathisrichter mathisrichter merged commit 1e1474b into lava-nc:main Mar 2, 2022
@mathisrichter mathisrichter deleted the permute branch March 2, 2022 14:33
mgkwill pushed a commit that referenced this pull request Jul 6, 2022
@weidel-p
changed Node to Nodes (#195)
fbb9dc6 
* changed Node to Nodes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilippPlank PhilippPlank PhilippPlank approved these changes

@awintel awintel awintel approved these changes

@bamsumit bamsumit Awaiting requested review from bamsumit

Assignees

@mathisrichter mathisrichter

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mathisrichter @PhilippPlank @awintel @bamsumit @mgkwill