New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tutorial bug fix #253
Tutorial bug fix #253
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR only changes two lines, setting the post_guard
instead of the pre_guard
and calling run_post_mgmt
instead of run_pre_mgmt
. That's fine for me.
Is there a reason why the |
They work, but to do what the tutorial is supposed to do, we would also need the lrn_guard to return true. The pre_mgmt phase is coupled with learning enabled. |
Thanks a lot for clarifying! |
Issue Number: #249
Objective of pull request: Tutorial07 should work again
Pull request checklist
Your PR fulfills the following requirements:
flakeheaven lint src/lava tests/
) and (bandit -r src/lava/.
) pass locallypytest
) passes locallyPull request type
Please check your PR type:
What is the current behavior?
What is the new behavior?
Does this introduce a breaking change?
Supplemental information