Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix improper cast in rf neuron process #487

Merged
merged 1 commit into from Nov 16, 2022

Conversation

Michaeljurado42
Copy link
Contributor

Issue Number: 472

Objective of pull request: Fix improper cast in rf neuron process

Pull request checklist

Your PR fulfills the following requirements:

  • Issue created that explains the change and why it's needed
  • [] Tests are part of the PR (for bug fixes / features)
  • Docs reviewed and added / updated if needed (for bug fixes / features)
  • PR conforms to Coding Conventions
  • PR applys BSD 3-clause or LGPL2.1+ Licenses to all code files
  • Lint (flakeheaven lint src/lava tests/) and (bandit -r src/lava/.) pass locally
  • Build tests (pytest) passes locally

Pull request type

Please check your PR type:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation changes
  • Other (please describe):

What is the current behavior?

  • Non singular rf neuron instantiations do not work

What is the new behavior?

  • Rf neurons with variable periods now work

Does this introduce a breaking change?

  • Yes
  • No

Supplemental information

The lava-dl rf netx PR relies upon this PR being accepted.

src/lava/proc/rf/process.py Show resolved Hide resolved
@bamsumit bamsumit merged commit cfbcae0 into lava-nc:main Nov 16, 2022
@Michaeljurado42 Michaeljurado42 deleted the multiple_rf_neurons branch November 16, 2022 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants