Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev/learning 2f on chip #528

Merged
merged 19 commits into from Dec 8, 2022
Merged

Dev/learning 2f on chip #528

merged 19 commits into from Dec 8, 2022

Conversation

weidel-p
Copy link
Contributor

@weidel-p weidel-p commented Dec 6, 2022

Issue Number:

Objective of pull request:

This PR makes some minor changes to the Learning architecture to enable 2F on-chip learning for Lava-Loihi. Most notably:

  • Introduction of the LearningLIF Process
  • Introduction of the InAxonAddress for Loihi to enable get/set of pre-traces

Pull request checklist

Your PR fulfills the following requirements:

  • Issue created that explains the change and why it's needed
  • Tests are part of the PR (for bug fixes / features)
  • Docs reviewed and added / updated if needed (for bug fixes / features)
  • PR conforms to Coding Conventions
  • PR applys BSD 3-clause or LGPL2.1+ Licenses to all code files
  • Lint (flakeheaven lint src/lava tests/) and (bandit -r src/lava/.) pass locally
  • Build tests (pytest) passes locally

Pull request type

Please check your PR type:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation changes
  • Other (please describe):

What is the current behavior?

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Supplemental information

@weidel-p weidel-p requested review from bala-git9 and gkarray and removed request for bala-git9 December 6, 2022 13:22
Copy link
Contributor

@bala-git9 bala-git9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor aesthetic changes that needs to done, but will still approve. Overall looks good.

src/lava/magma/core/learning/learning_rule.py Outdated Show resolved Hide resolved
src/lava/magma/core/model/py/connection.py Outdated Show resolved Hide resolved
src/lava/magma/core/model/py/connection.py Show resolved Hide resolved
src/lava/proc/lif/process.py Outdated Show resolved Hide resolved
Copy link
Contributor

@gkarray gkarray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@weidel-p weidel-p merged commit da369b9 into main Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants