[v3] Add custom sentry tags #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thought this one was not a breaking change either, but it kinda builds upon 2557262 so...nope, not backporting it to dev. |
freyacodes
approved these changes
May 20, 2018
|
It kinda is a breaking change, as it changes the location of the DSN and deprecates the old one. |
freyacodes
pushed a commit
to freyacoded/repo-test
that referenced
this pull request
Oct 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default sentry tags the server name. This PR allows to set optional additional custom tags for a lavalink server instance, which then can be sorted by in sentry. This PR is useful when running more than one LL instance on one machine for example, or otherwise group and sort through reports of various instances.
Moved the sentry configuration into its own configuration key / class to avoid cluttering the server configuration. The previous dsn location is deprecated, but still supported and will result in a friendly warning detailing the new location / configuration key, until it is removed in a version post v3.