CNS-850: unbond stake entry bug #1199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yaroms
reviewed
Feb 8, 2024
|
Instead of checking for 0, add a param, min_stake (ulava coin), if the stake is less than that, unstake the provider |
Yaroms
reviewed
Feb 11, 2024
Yaroms
reviewed
Feb 11, 2024
…' of github.com:lavanet/lava into CNS-850-audit-inflating-memory-with-empty-stake-entries
omerlavanet
requested changes
Feb 19, 2024
added 2 commits
February 20, 2024 12:02
omerlavanet
requested changes
Feb 20, 2024
added 2 commits
February 20, 2024 18:01
omerlavanet
requested changes
Feb 21, 2024
omerlavanet
approved these changes
Feb 26, 2024
Yaroms
deleted the
CNS-850-audit-inflating-memory-with-empty-stake-entries
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I fix a small bug in which there's a code flow that allowed a provider to fully unbond its stake, but the stake entry is not removed (and there is no unstake entry)