Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PRT-292 incorrect account sequence no payments to providers #253

Merged

Conversation

ranlavanet
Copy link
Contributor

  • Please check if the PR fulfills these requirements
  • Commit message follows the Contribution Guidelines
  • Tests ran locally and added/modified if needed
  • Docs have been added/updated, if applicable
  • If applicable - JIRA ticket ID was added
  • What kind of change does this PR introduce? (Bug fix, feature, unit tests, docs update, ...)
    Retry mechanism for sequence number errors on payment requests by the expected sequence number.
    Also, splitting the payment requests into a random block in an epoch instead of all payment requests on the first block.

  • What is the current behavior? (You can also link to an open issue here)
    currently fails and doesnt parse the errors correctly and always asking rewards on the first block in an epoch

  • What is the new behavior (if this is a feature change)?
    Retry mechanism for sequence number errors on payment requests by the expected sequence number.
    Also, splitting the payment requests into a random block in an epoch instead of all payment requests on the first block.

  • Please describe what manual tests you ran, if applicable
    testing multiple payment requests from the same provider in different processes, resulting in reproducing the problem and fixing it

  • Other information:

relayer/server.go Show resolved Hide resolved
relayer/server.go Show resolved Hide resolved
@omerlavanet omerlavanet merged commit ace005d into main Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants