PRT-355 Rename e2e test file #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kajeagentspi
changed the title
|
@kajeagentspi please add the eth fixes to this pr so we can merge this to main |
kajeagentspi
force-pushed
the
PRT-355-fix-e-2-e-not-running
branch
2 times, most recently
from
8d9dd0c
to
356eff7
Compare
kajeagentspi
force-pushed
the
PRT-355-fix-e-2-e-not-running
branch
from
356eff7
to
a223a23
Compare
Aleksao998
previously requested changes
Jan 25, 2023
There was a problem hiding this comment.
The code looks good 🚀 i see that tests passed on github actions, but when i ran them locally using:
go test ./testutil/e2e/ -v -timeout 1200s
i get an panic:
Jan 25 13:41:14 INF Waiting JSONRPC Gateway
panic: Error found in logs
goroutine 538 [running]:
github.com/lavanet/lava/testutil/e2e.(*lavaTest).saveLogs(0xc000d8f900)
/home/aleksaopacic/Documents/Projects/lava/testutil/e2e/e2e.go:681 +0x49e
github.com/lavanet/lava/testutil/e2e.(*lavaTest).listenCmdCommand(0xc000d8f900, 0x0?, {0x145513e, 0x31}, {0x141fb4b, 0x13})
/home/aleksaopacic/Documents/Projects/lava/testutil/e2e/e2e.go:259 +0xa9
github.com/lavanet/lava/testutil/e2e.(*lavaTest).startJSONRPCGateway.func1()
/home/aleksaopacic/Documents/Projects/lava/testutil/e2e/e2e.go:240 +0x3a
created by github.com/lavanet/lava/testutil/e2e.(*lavaTest).startJSONRPCGateway
/home/aleksaopacic/Documents/Projects/lava/testutil/e2e/e2e.go:239 +0x2ed
FAIL github.com/lavanet/lava/testutil/e2e 52.915s
FAIL
Jan 25 13:41:14 INF Waiting JSONRPC Gateway
panic: Error found in logs
goroutine 538 [running]:
github.com/lavanet/lava/testutil/e2e.(*lavaTest).saveLogs(0xc000d8f900)
/home/aleksaopacic/Documents/Projects/lava/testutil/e2e/e2e.go:681 +0x49e
github.com/lavanet/lava/testutil/e2e.(*lavaTest).listenCmdCommand(0xc000d8f900, 0x0?, {0x145513e, 0x31}, {0x141fb4b, 0x13})
/home/aleksaopacic/Documents/Projects/lava/testutil/e2e/e2e.go:259 +0xa9
github.com/lavanet/lava/testutil/e2e.(*lavaTest).startJSONRPCGateway.func1()
/home/aleksaopacic/Documents/Projects/lava/testutil/e2e/e2e.go:240 +0x3a
created by github.com/lavanet/lava/testutil/e2e.(*lavaTest).startJSONRPCGateway
/home/aleksaopacic/Documents/Projects/lava/testutil/e2e/e2e.go:239 +0x2ed
FAIL github.com/lavanet/lava/testutil/e2e 52.915s
FAIL
Do you know why is this happening?
|
I also get a panic |
ranlavanet
approved these changes
Jan 25, 2023
ranlavanet
dismissed
Aleksao998’s stale review
we need this merged we dont have any tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, unit tests, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Please describe what manual tests you ran, if applicable
Other information: