Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing quotes on response #262

Merged
merged 6 commits into from
Jan 26, 2023

Conversation

Aleksao998
Copy link
Contributor

@Aleksao998 Aleksao998 commented Jan 24, 2023

  • Please check if the PR fulfills these requirements
  • Commit message follows the Contribution Guidelines
  • Tests ran locally and added/modified if needed
  • Docs have been added/updated, if applicable
  • If applicable - JIRA ticket ID was added
  • What kind of change does this PR introduce? (Bug fix, feature, unit tests, docs update, ...)

BugFix

  • What is the current behavior? (You can also link to an open issue here)

The current implementation is missing " on some response attributes. Because of this we can not parse all responses

  • What is the new behavior (if this is a feature change)?

All responses should be parsable

  • Please describe what manual tests you ran, if applicable

I've manually tested all error responses and non have parsing issue anymore, also i tried to construct the malicious XSS attack and the marshal escapes all special characters

  • Other information:

@Aleksao998 Aleksao998 marked this pull request as draft January 24, 2023 23:36
@ranlavanet ranlavanet self-requested a review January 25, 2023 08:40
@Aleksao998 Aleksao998 force-pushed the bugfix/fix_missing_quotes_in_response branch from d64fdd9 to d4c6fb4 Compare January 25, 2023 12:05
@Aleksao998 Aleksao998 marked this pull request as ready for review January 25, 2023 12:31
@Aleksao998 Aleksao998 self-assigned this Jan 25, 2023
@Aleksao998 Aleksao998 added the bug Something isn't working label Jan 25, 2023
@omerlavanet omerlavanet self-requested a review January 26, 2023 09:23
relayer/chainproxy/jsonRPC.go Outdated Show resolved Hide resolved
@omerlavanet omerlavanet merged commit 0e2f576 into main Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants