CNS-262: changed payment objects to hold keys, not pointers #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yaroms
requested changes
Jan 30, 2023
oren-lava
force-pushed
the
CNS-262-change-pointers-to-keys-in-payment-objects
branch
from
be0fd69
to
057144c
Compare
Yaroms
approved these changes
Jan 31, 2023
Yaroms
requested changes
Jan 31, 2023
Yaroms
previously approved these changes
Jan 31, 2023
omerlavanet
previously approved these changes
Feb 1, 2023
omerlavanet
approved these changes
Feb 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, unit tests, docs update, ...)
Bug fix
What is the current behavior? (You can also link to an open issue here)
The payment object epochPayments holds a list of providerPaymentStorage pointers. The providerPaymentStorage object holds a list of uniquePaymentStorageClientProvider pointers. In addition, the epochPayments, providerPaymentStorage and uniquePaymentStorageClientProvider are saved separately in the KVStore. This caused duplicates of objects. For example, if there was only one payment for a specific provider, two objects were created: a providerPaymentStorage object stored directly in the KVStore and a providerPaymentStorage object that its pointer was part of the epochPayments object's list of providerPaymentStorage pointers.
What is the new behavior (if this is a feature change)?
Instead of keeping lists of pointers, each payment object now holds a unique string key that can be used to access payment objects. This way, there will be no more duplications since all the objects are saved once in the KVStore.
Please describe what manual tests you ran, if applicable
Other information: