Prt 405 redesign chain proxy #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…redesign-api-lib-implementation
…to PRT-303-rpc-consumer-redesign-api-lib-implementation
…to PRT-303-rpc-consumer-redesign-api-lib-implementation
…i-lib-implementation' into PRT-405-redesign-chain-proxy
ranlavanet
previously approved these changes
Feb 1, 2023
ranlavanet
approved these changes
Feb 1, 2023
orenl-lava
added a commit
that referenced
this pull request
Feb 5, 2023
orenl-lava
added a commit
that referenced
this pull request
Feb 14, 2023
orenl-lava
added a commit
that referenced
this pull request
Feb 14, 2023
orenl-lava
added a commit
that referenced
this pull request
Feb 14, 2023
orenl-lava
added a commit
that referenced
this pull request
Feb 16, 2023
omerlavanet
pushed a commit
that referenced
this pull request
Feb 16, 2023
* CNS-250: introduce spec inheritance syntax Extend the spec syntax to add the ability for a spec to inherit/import another spec. With spec inheritance, changes in an ancestor spec (a.k.a base spec) would immediately propagate to all descendants specs that inherit from it. Spec inheritance is recursive, and applied only the APIs defined (not general spec parameters). APIs in current spec override inherited APIs, but duplicates (from multiple ancestors) are not allowed. An override with 'Enabled: false' effectively removes an API). Spec inheritance is valitaded when submitting a spec proposal. * CNS-250: query spec to return full (expanded) spec For compatibility, query for spec(s) should return fully expanded spec(s). This is also serves stake-provider when they query the spec, as they need to validate and implement inherited APIs too. * CNS-250: allow duplicate imported api with override Allow import with duplicate API when the current Spec anyhow overrides that API. (Normally, import of duplicate API is not allowed). * Fix linter errors introduced by PR #279
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, unit tests, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Please describe what manual tests you ran, if applicable
Other information: