Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CNS-291: Implemented fixation entry lib #306

Merged
merged 18 commits into from
Feb 27, 2023
Merged

CNS-291: Implemented fixation entry lib #306

merged 18 commits into from
Feb 27, 2023

Conversation

oren-lava
Copy link
Collaborator

  • Please check if the PR fulfills these requirements
  • [ V ] Commit message follows the Contribution Guidelines
  • [ V ] Tests ran locally and added/modified if needed
  • [ V ] Docs have been added/updated, if applicable
  • [ V ] If applicable - JIRA ticket ID was added

  • What kind of change does this PR introduce? (Bug fix, feature, unit tests, docs update, ...)
    feature

  • What is the current behavior? (You can also link to an open issue here)
    no standard lib for handling fixation entries

  • What is the new behavior (if this is a feature change)?
    I've implemented a lib for fixation entries handling with comfortable APIs to add, edit, remove and get entries

  • Please describe what manual tests you ran, if applicable
    I've implemented a set of unit tests to test the lib

  • Other information:

Yaroms
Yaroms requested changes Feb 19, 2023
View reviewed changes
testutil/keeper/keepers_init.go Outdated Show resolved Hide resolved
x/pairing/types/keys.go Outdated Show resolved Hide resolved
Yaroms
Yaroms requested changes Feb 19, 2023
View reviewed changes
common/fixation_entry_test.go Outdated Show resolved Hide resolved
Yaroms
Yaroms previously approved these changes Feb 19, 2023
View reviewed changes
omerlavanet
omerlavanet requested changes Feb 19, 2023
View reviewed changes
common/fixation_entry.go Outdated Show resolved Hide resolved
common/fixation_entry_unique_index.go Outdated Show resolved Hide resolved
common/fixation_entry_unique_index.go Outdated Show resolved Hide resolved
common/fixation_entry_unique_index_test.go Outdated Show resolved Hide resolved
common/fixation_entry.go Outdated Show resolved Hide resolved
Yaroms
Yaroms reviewed Feb 20, 2023
View reviewed changes
common/fixation_entry.go Outdated Show resolved Hide resolved
common/fixation_entry_unique_index.go Outdated Show resolved Hide resolved
common/fixation_entry_unique_index.go Outdated Show resolved Hide resolved
common/fixation_entry_unique_index.go Outdated Show resolved Hide resolved
Yaroms
Yaroms requested changes Feb 21, 2023
View reviewed changes
common/fixation_entry.go Outdated Show resolved Hide resolved
common/fixation_entry.go Outdated Show resolved Hide resolved
common/fixation_entry.go Outdated Show resolved Hide resolved
common/fixation_entry.go Outdated Show resolved Hide resolved
common/fixation_entry.go Outdated Show resolved Hide resolved
common/fixation_entry.go Outdated Show resolved Hide resolved
common/types/constants.go Outdated Show resolved Hide resolved
orenl-lava
orenl-lava reviewed Feb 24, 2023
View reviewed changes
common/fixation_entry.go Outdated Show resolved Hide resolved
common/fixation_entry.go Outdated Show resolved Hide resolved
common/fixation_entry.go Outdated Show resolved Hide resolved
common/fixation_entry.go Outdated Show resolved Hide resolved
proto/common/fixationEntry.proto Outdated Show resolved Hide resolved
common/fixation_entry.go Outdated Show resolved Hide resolved
common/fixation_entry_index.go Outdated Show resolved Hide resolved
common/fixation_entry_index.go Outdated Show resolved Hide resolved
common/fixation_entry_index.go Outdated Show resolved Hide resolved
common/fixation_entry_test.go Outdated Show resolved Hide resolved
Yaroms
Yaroms reviewed Feb 26, 2023
View reviewed changes
common/fixation_entry.go Outdated Show resolved Hide resolved
common/fixation_entry.go Outdated Show resolved Hide resolved
common/fixation_entry.go Outdated Show resolved Hide resolved
common/fixation_entry.go Outdated Show resolved Hide resolved
common/fixation_entry.go Outdated Show resolved Hide resolved
common/fixation_entry.go Outdated Show resolved Hide resolved
common/fixation_entry_index.go Outdated Show resolved Hide resolved
common/fixation_entry_test.go Show resolved Hide resolved
common/fixation_entry_test.go Show resolved Hide resolved
common/fixation_entry.go Outdated Show resolved Hide resolved
Yaroms
Yaroms requested changes Feb 26, 2023
View reviewed changes
common/fixation_entry.go Outdated Show resolved Hide resolved
Yaroms
Yaroms previously approved these changes Feb 26, 2023
View reviewed changes
omerlavanet
omerlavanet requested changes Feb 26, 2023
View reviewed changes
common/fixation_entry.go Outdated Show resolved Hide resolved
common/fixation_entry.go Show resolved Hide resolved
common/fixation_entry.go Outdated Show resolved Hide resolved
common/fixation_entry.go Outdated Show resolved Hide resolved
common/fixation_entry.go Outdated Show resolved Hide resolved
common/fixation_entry_index.go Outdated Show resolved Hide resolved
common/fixation_entry_index.go Outdated Show resolved Hide resolved
common/fixation_entry.go Outdated Show resolved Hide resolved
common/fixation_entry_test.go Show resolved Hide resolved
common/fixation_entry_test.go Show resolved Hide resolved
Yaroms
Yaroms requested changes Feb 26, 2023
View reviewed changes
common/fixation_entry.go Outdated Show resolved Hide resolved
common/fixation_entry.go Outdated Show resolved Hide resolved
common/fixation_entry.go Outdated Show resolved Hide resolved
omerlavanet
omerlavanet previously approved these changes Feb 27, 2023
View reviewed changes
orenl-lava
orenl-lava reviewed Feb 27, 2023
View reviewed changes
common/fixation_entry_index.go Show resolved Hide resolved
common/types/keys.go Outdated Show resolved Hide resolved
common/fixation_entry.go Outdated Show resolved Hide resolved
common/fixation_entry.go Outdated Show resolved Hide resolved
common/fixation_entry.go Outdated Show resolved Hide resolved
common/fixation_entry.go Outdated Show resolved Hide resolved
common/fixation_entry.go Outdated Show resolved Hide resolved
common/fixation_entry.go Outdated Show resolved Hide resolved
common/fixation_entry.go Show resolved Hide resolved
common/fixation_entry.go Outdated Show resolved Hide resolved
Yaroms
Yaroms approved these changes Feb 27, 2023
View reviewed changes
common/fixation_entry.go Outdated Show resolved Hide resolved
common/fixation_entry_index.go Show resolved Hide resolved
@Yaroms Yaroms merged commit fe45197 into main Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orenl-lava orenl-lava orenl-lava left review comments

@Yaroms Yaroms Yaroms approved these changes

@omerlavanet omerlavanet omerlavanet left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@oren-lava @omerlavanet @Yaroms @orenl-lava