CNS-169 implement module subscription #329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
orenl-lava
force-pushed
the
CNS-169-implement-module-subscription
branch
from
967d4c7
to
aa42352
Compare
oren-lava
previously requested changes
Feb 28, 2023
Yaroms
requested changes
Mar 1, 2023
orenl-lava
force-pushed
the
CNS-169-implement-module-subscription-scaffold
branch
from
00eaf54
to
92389df
Compare
orenl-lava
force-pushed
the
CNS-169-implement-module-subscription
branch
4 times, most recently
from
6da6420
to
fec74c2
Compare
GetPlan() - drop block arg, because we always use current block. PutPlan() - do not return the Plan, because we drop it anway.
Porperly initialize the module in app.go, and add deps account,bank.
ignite scaffold type subscription \
creator:string \
consumer:string \
block:uint \
plan_index:string \
plan_block:uint \
is_yearly:bool \
expiry_time:uint \
usedCU:uint \
remainingCU:uint \
--no-message \
--module subscription
ignite scaffold message subscribe \
consumer:string
index:string
is_yearly:bool
--module subscription
--desc "Subscribe to a service plan"
To add a subscription: lavad tx subscription subscribe [CONSUMER] [PLAN] [IS_YEARLY] [flags] Where: CONSUMER: address of the consumer that will use this subscription PLAN: unique index of the plan to subscribe to IS_YEARLY: whether the subscription is for a year (for discounted rate)
orenl-lava
force-pushed
the
CNS-169-implement-module-subscription
branch
from
fec74c2
to
70b1629
Compare
orenl-lava
changed the base branch from
CNS-169-implement-module-subscription-scaffold
to
main
orenl-lava
changed the base branch from
main
to
CNS-169-implement-module-subscription-scaffold
orenl-lava
force-pushed
the
CNS-169-implement-module-subscription-scaffold
branch
from
92389df
to
cb24608
Compare
Yaroms
approved these changes
Mar 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement module subscription basics and the "subscribe" message,
This module depends on the Packages module, so tested with a local mock (not included in PR).
Note that the PR depends on #328 .
What kind of change does this PR introduce? (Bug fix, feature, unit tests, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Please describe what manual tests you ran, if applicable
Other information: