Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNS-231 unitests tests and fixes #336

Conversation

Yaroms
Copy link
Collaborator

@Yaroms Yaroms commented Mar 2, 2023

  • Please check if the PR fulfills these requirements
  • Commit message follows the Contribution Guidelines
  • Tests ran locally and added/modified if needed
  • Docs have been added/updated, if applicable
  • If applicable - JIRA ticket ID was added
  • What kind of change does this PR introduce? (Bug fix, feature, unit tests, docs update, ...)

  • What is the current behavior? (You can also link to an open issue here)

  • What is the new behavior (if this is a feature change)?

  • Please describe what manual tests you ran, if applicable

  • Other information:

testutil/keeper/keepers_init.go Outdated Show resolved Hide resolved
testutil/keeper/keepers_init.go Outdated Show resolved Hide resolved
x/projects/keeper/msg_server_add_project_keys.go Outdated Show resolved Hide resolved
x/projects/keeper/project_test.go Outdated Show resolved Hide resolved
x/projects/keeper/project_test.go Show resolved Hide resolved
@Yaroms Yaroms changed the title adding tests and fixes CBS-231 unitests tests and fixes Mar 2, 2023
Copy link
Contributor

@orenl-lava orenl-lava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing tests:

  • DeleteProject()
  • Versions of projects (and their disappearance)

testutil/keeper/keepers_init.go Show resolved Hide resolved
testutil/keeper/keepers_init.go Show resolved Hide resolved
testutil/keeper/keepers_init.go Show resolved Hide resolved
x/projects/keeper/msg_server_add_project_keys.go Outdated Show resolved Hide resolved
x/projects/keeper/msg_server_add_project_keys.go Outdated Show resolved Hide resolved
@Yaroms
Copy link
Collaborator Author

Yaroms commented Mar 2, 2023

Missing tests:

  • DeleteProject()
  • Versions of projects (and their disappearance)

do we need to test this? it should be a fixation test

@Yaroms Yaroms changed the base branch from CNS-231-consumer-create-project-scaffold-txs to CNS-231-consumer-create-project March 2, 2023 20:17
@Yaroms Yaroms requested a review from orenl-lava March 2, 2023 20:20
@orenl-lava orenl-lava changed the title CBS-231 unitests tests and fixes CNS-231 unitests tests and fixes Mar 3, 2023
@Yaroms Yaroms merged commit 64a8ba0 into CNS-231-consumer-create-project Mar 3, 2023
@Yaroms Yaroms deleted the CNS-231-consumer-create-project-unitests branch July 31, 2023 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants