Long running closure blocks other tasks

[esetnik]

Crunz version: x.y.z
v2.0.2
PHP version: x.y.z
v7.3.11
Operating system type and version:
docker php:7.3-fpm
Description
Running a long running task in closure blocks other tasks from executing.

How to reproduce
LongRunningTasks.php

$event = $schedule->run(function () {
        while (true) {
            echo 'output';
        }

})
->description('long-running-task')
->preventOverlapping();
$event
    ->everyMinute();

$event2 = $schedule->run(function () {
            echo 'another task';
})
->description('long-running-task')
->preventOverlapping();

$event2
    ->everyMinute();

return $schedule;

Possible Solution
The lavary implementation looks similar to the symphony process implementation for running processes asynchronously so I'm not sure why it doesn't work.

https://symfony.com/doc/current/components/process.html

$process = new Process(['ls', '-lsa']);
$process->start();

while ($process->isRunning()) {
    // waiting for process to finish
}

echo $process->getOutput();

Additional context

[PabloKowalczyk]

Did you mean, run long running task in one terminal, then try to run Crunz again with another terminal and other tasks from long running file will not be run?

[esetnik]

No I mean that there'd be a single cron running with multiple tasks, one of those tasks will run forever, e.g. example above with infinite loop. The use case is to have an AWS SQS receive message task looping and being spawned by a crunz scheduler. In the example above, if I keep the first task looping, the second task never executes.

[PabloKowalczyk]

Sorry, I mean "is it a correct way to reproduce the issue?", but looks like it is.

[PabloKowalczyk]

Hey @esetnik, could you run Crunz with -vvv option?

[PabloKowalczyk]

Interesting issue, seems that there were two errors (both fixed). First, as described in #264, version v2.x changes behavior of Closures' return value, so Closures from your example were failing and this leads to second bug, locks were not released on task's error (fixed in #261). Test it with v2.0.4 release.

Thanks @esetnik.

[esetnik]

Thank you for taking the time to look into this issue for me. I will update you once I get a chance to test this out. The solution seems reasonable and explains the odd behavior I was seeing.

[PabloKowalczyk]

@esetnik what about this issue? Could it be closed?

[esetnik]

@PabloKowalczyk I apologize for the delay in getting back to you. This issue appears to be fixed now. Although it should be noted that a long running task which outputs to the console will eventually run out of memory due to #152 as far as I know.

[PabloKowalczyk]

#152 is a different topic, as a quick fix you could suppress any output from your "long running task" - should help.

I'm closing this issue, thanks @esetnik.