Skip to content

Commit

Permalink
CI: Update actions and fix prebuild on osx
Browse files Browse the repository at this point in the history
  • Loading branch information
orgads committed Jan 17, 2024
1 parent 2bee3d5 commit 8401ddd
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 7 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
# https://github.com/nodejs/node-gyp/issues/2869
- run: python3 -m pip install setuptools
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v3
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node-version }}
- name: Add msbuild to PATH
Expand All @@ -33,7 +33,7 @@ jobs:
with:
max_attempts: 3
retry_on: error
timeout_seconds: 240
timeout_minutes: 6
command: |
npm test
Expand All @@ -44,7 +44,7 @@ jobs:
node-version: [ 16, 18, 20 ]
container: node:${{ matrix.node-version }}-alpine
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- name: install build deps
run: |
apk add g++ make python3
Expand Down
10 changes: 6 additions & 4 deletions .github/workflows/prebuild.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,11 @@ jobs:
os: [ubuntu-20.04, macos-latest, windows-latest]
fail-fast: false
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
# https://github.com/nodejs/node-gyp/issues/2869
- run: python3 -m pip install setuptools
- name: Use Node.js 18.x
uses: actions/setup-node@v3
uses: actions/setup-node@v4
with:
node-version: 18.x
- name: Add msbuild to PATH
Expand All @@ -39,9 +41,9 @@ jobs:

prebuild-alpine:
runs-on: ubuntu-latest
container: node:18-alpine3.18
container: node:18-alpine3.19
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- name: install build deps
run: |
apk add g++ make python3
Expand Down

0 comments on commit 8401ddd

Please sign in to comment.