Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Update actions and fix prebuild on osx #444

Merged
merged 3 commits into from
Jan 19, 2024
Merged

CI: Update actions and fix prebuild on osx #444

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2bee3d5
Fix use-after-free
orgads Jan 17, 2024
8401ddd
CI: Update actions and fix prebuild on osx
orgads Jan 17, 2024
db7e18b
Merge branch 'main' into ci-up
laverdet Jan 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
# https://github.com/nodejs/node-gyp/issues/2869
- run: python3 -m pip install setuptools
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v3
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node-version }}
- name: Add msbuild to PATH
Expand All @@ -33,7 +33,7 @@ jobs:
with:
max_attempts: 3
retry_on: error
timeout_seconds: 240
timeout_minutes: 6
command: |
npm test

Expand All @@ -44,7 +44,7 @@ jobs:
node-version: [ 16, 18, 20 ]
container: node:${{ matrix.node-version }}-alpine
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- name: install build deps
run: |
apk add g++ make python3
Expand Down
10 changes: 6 additions & 4 deletions .github/workflows/prebuild.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,11 @@ jobs:
os: [ubuntu-20.04, macos-latest, windows-latest]
fail-fast: false
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
# https://github.com/nodejs/node-gyp/issues/2869
- run: python3 -m pip install setuptools
- name: Use Node.js 18.x
uses: actions/setup-node@v3
uses: actions/setup-node@v4
with:
node-version: 18.x
- name: Add msbuild to PATH
Expand All @@ -39,9 +41,9 @@ jobs:

prebuild-alpine:
runs-on: ubuntu-latest
container: node:18-alpine3.18
container: node:18-alpine3.19
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- name: install build deps
run: |
apk add g++ make python3
Expand Down