Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to arm64 #293

Conversation

TomFreudenberg
Copy link
Contributor

Hi Marcel ( @laverdet )

would you like to add that patch so that node-fibers also will work on arm64.

Cheers
Tom

@TomFreudenberg
Copy link
Contributor Author

Hi Marcel ( @laverdet )

could you be so kind to inform me just about your thoughts about this PR. Will you include it or may I do something in addition to get that work?

I can confirm now running meteor/node apps on ARM64 (linaro cluster and other device) using the patched fibers from our repository. 4commerce-technologies-AG/meteor#42

Thanks for a short info
Tom

@laverdet
Copy link
Owner

laverdet commented Jul 3, 2016

It looks fine, I will include it in the next round of maintenance

@TomFreudenberg
Copy link
Contributor Author

Thanks Marcel

@TomFreudenberg
Copy link
Contributor Author

Hi @laverdet Marcel

Do you have a timeline or expectation when next node-fibers will be released where this PR is included?

Thanks for a short note in advance
Tom

@laverdet
Copy link
Owner

Unless there's any critical bugs that come up and I can slip this in with another release, then probably around October when Node cuts v7 and people need new binaries. Because fibers is feature-complete and in maintenance mode, unless there's a compelling reason I try not to cut too many releases because even small changes affect teams using fibers.

@TomFreudenberg
Copy link
Contributor Author

Hi Marcel, thanks for that info. I will have to check what the release date for meteor 1.4 will be but I guess it is before October. So I will provide the our fork of node-fibers until you have done the new release.

@laverdet
Copy link
Owner

Merged in ef67c62.

@laverdet laverdet closed this Aug 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants