Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace charade by chardet #67

Merged
merged 1 commit into from
Jul 14, 2016
Merged

replace charade by chardet #67

merged 1 commit into from
Jul 14, 2016

Conversation

smihai
Copy link
Contributor

@smihai smihai commented Jul 8, 2016

As the README of charade package suggests

@coveralls
Copy link

coveralls commented Jul 8, 2016

Coverage Status

Coverage remained the same at 92.119% when pulling dbf7d7e on smihai:master into 4bbdc7d on lavr:master.

@@ -4,7 +4,7 @@

import re
import cgi
import charade
import chardet
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although you updated install_requires, I suppose we should provide some fallback here, like this:

try:
    import charade as chardet
    warnings.warn("charade module is deprecated, update your requirements to chardet", DeprecationWarning)
except ImportError:
    import chardet

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree.
Commits rebased into one

@lavr
Copy link
Owner

lavr commented Jul 11, 2016

Please, rebase all commits to one commit.
Thanx

@coveralls
Copy link

coveralls commented Jul 11, 2016

Coverage Status

Coverage decreased (-0.04%) to 92.084% when pulling efd4874 on smihai:master into 4bbdc7d on lavr:master.

@coveralls
Copy link

coveralls commented Jul 11, 2016

Coverage Status

Coverage increased (+0.2%) to 92.317% when pulling efd4874 on smihai:master into 4bbdc7d on lavr:master.

@lavr lavr merged commit 399d636 into lavr:master Jul 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants