Document how to apply Premailer #90
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Did I get it right?
lavr
requested changes
Jul 7, 2017
| >>> html = '''<style>h1 { color: red }</style> | ||
| ... <h1>Hello world!</h1>''' | ||
| >>> message = emails.Message(html=html) | ||
| >>> message.transformer.premailer.transform() |
There was a problem hiding this comment.
Premailer is a great library, but using it's abstractions here looks a little confusing for me.
Supposed way to do basic transformations is Transformer.load_and_transform:
message = emails.Message(html='''<style>h1 { color: red }</style>
<h1>Hello world!</h1>''')
message.transformer.load_and_transform()
message.transformer.save()
print(message.html)
There was a problem hiding this comment.
Do you think that this example and the previous one (about images inlining) should be replaced with one bigger example that explains the arguments to load_and_transform?
There was a problem hiding this comment.
Not sure. I don't like this code now. I think should add message.transform method that incapsulates load_and_transform & save
There was a problem hiding this comment.
Sounds good to me. Well then, I’ll withdraw this PR for now.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did I get it right?