-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
placeholderTextColor not being set #100
Comments
- This PR fixes the bug that wouldn't set the `textPlaceholderColor` if the `placeholder` label was not present on the `items` and was not currewntly selected. - The fix simply removes this condition, since I see no reason to have this condition for this purpose. (Any thoughts?) - Also, implement test cases for this use case Closes: lawnstarter#100
- This PR fixes the bug that wouldn't set the `textPlaceholderColor` if the `placeholder` label was not present on the `items` and was not currewntly selected. - The fix simply removes this condition, since I see no reason to have this condition for this purpose. (Any thoughts?) - Also, implement test cases for this use case Closes: lawnstarter#100
Maybe I'm not understanding the issue here. See the first use of the component here: https://snack.expo.io/rk1XLLpjQ I added a placeholderTextColor, the placeholder itself is different from the default, and it works as I'm expecting it to. Are you expecting something different? |
@lfkwtz You are right. I was following the docs for version 5.0.0, but was using version 4.2.0, once I checked the releases, I notices that version 4.4.0 was when the |
All good. Glad it was an straightforward answer. |
How to change placeholderTextColor in Android? |
@lfkwtz Changing the placeholderTextColor is still not working on iOS. Is there anything else that needs to be done since the info is not in the docs? |
look at the sample app |
@NathanNovak I did this and it works :
|
The issue is still persisting. |
I too have this issue, tried the above but with no luck |
is this issue resolved, for me placeholderTextColor not working |
placeholder:{ // Add these lines in pickerSelectStyle |
1 similar comment
placeholder:{ // Add these lines in pickerSelectStyle |
Describe the bug
The
placeholderTextColor
is not being set whenever one wants to set a different placeholder text to the ones you want to display as values. Such as this:To Reproduce
Picker
componentplaceholderTextColor
items
Expected behavior
The placeholder text color should change to red. However, because of this line: https://github.com/lawnstarter/react-native-picker-select/blob/master/src/index.js#L193 the
color
attribute is never set.Screenshots
Reproduction and/or code sample
In order to reproduce the behaviour, just create the following component:
The text was updated successfully, but these errors were encountered: