Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KeyboardAvoidingView triggering #94

Closed
rickysullivan opened this issue Oct 15, 2018 · 3 comments
Closed

KeyboardAvoidingView triggering #94

rickysullivan opened this issue Oct 15, 2018 · 3 comments

Comments

@rickysullivan
Copy link
Contributor

rickysullivan commented Oct 15, 2018

Describe the bug
When using <KeyboardAvoidingView>. On iOS, the TextInput, which is used to trigger the picker, is triggering the KeyboardAvoidingView into squashing the view for a split second.

Steps to reproduce
Steps to reproduce the behaviour:

  1. Wrap <RNPickerSelect /> with a <KeyboardAvoidingView>
  2. Being filling out form, using the keyboard's Next key to focus the next TextInput.
  3. See KeyboardAvoidingView triggering/flickering when clicking Done on the picker.

It will also flicker when taping the picker item at any point when the keyboard is open.

Expected behaviour:
Would be nice to not have the KeyboardAvoidingView trigger.

Smartphone:

  • Device: iPhone5
  • OS: iOS 10.3.3
  • react-native-picker-select version: 4.4.0
  • react-native version: 0.55.4
  • react version: 16.3.1

Reproduction and/or code sample
https://snack.expo.io/@rickysullivan/keyboardavoidingview

Possible solution
Adding editable={false} to the TextInput inside renderTextInputOrChildren().

@lfkwtz
Copy link
Collaborator

lfkwtz commented Oct 19, 2018

wasn't able to replicate, but added editable={false} in #91 --- let me know if that fixes it for you

@lfkwtz
Copy link
Collaborator

lfkwtz commented Oct 31, 2018

@rickysullivan - any update?

@rickysullivan
Copy link
Contributor Author

Sorry @lfkwtz, been trying to get a project out the door.

I've re-tested using 5.0.1 and it seems to be working nicely.

I'll remove my setTimeout() wrappers in my app and see how it goes, but from my initial snack testing, it's all good.

4.4.0 5.0.1
picker-flick 4 4 0 picker-flick 5 0 1

martinglova pushed a commit to martinglova/react-native-picker-select that referenced this issue Dec 14, 2018
lfkwtz added a commit that referenced this issue Jan 4, 2019
* Dismiss keyboard when the picker is opened

Resolves #123 and does not re-open #94

* added test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants