Add Icon prop to component
#105
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luizParreira
force-pushed
the
feature/add-custom-icon
branch
from
8ea24de
to
752ed30
Compare
lfkwtz
requested changes
Nov 9, 2018
src/index.js
Outdated
| @@ -416,6 +423,7 @@ export default class RNPickerSelect extends PureComponent { | |||
| > | |||
| {this.renderPickerItems()} | |||
| </Picker> | |||
| {Icon && this.renderIcon()} | |||
There was a problem hiding this comment.
not a fan of this syntax personally -- would prefer:
{Icon ? this.renderIcon() : null}
luizParreira
force-pushed
the
feature/add-custom-icon
branch
2 times, most recently
from
e397da3
to
ae333fb
Compare
- Adding the possibility of the user passing a custom `Icon` prop to be rendered instead of the default one - Added README.md instructions - Add tests for the new behaviour - Change testID keys to not mindd about platforms anymore - Refactored renderAndroid because of `Cognitive Complexity` issue on code climate
luizParreira
force-pushed
the
feature/add-custom-icon
branch
from
ae333fb
to
ce056cc
Compare
|
Can you share some sample code of this working as intended on ios and android? Ideally on snack.expo.io |
|
Any plan to get this merged? Since @luizParreira already did the testing, adding one picker using the new prop in the |
|
I tested it myself locally and it wasn’t working as I imagine it should - which is why I’m asking for working examples |
|
I see, makes sense 👍 |
|
Going to close this out as I haven't heard from you in a couple months. We can re-open later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Iconprop to berendered instead of the default one
Closes #104