Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@react-native-picker/picker as a peerDependency to solve duplicate/Invariant violation issue #464

Closed

Conversation

Rehubbard
Copy link

@Rehubbard Rehubbard commented Oct 25, 2021

Problem

On a fresh install and following the readme steps, you end up with 2 versions of @react-native-picker/picker installed. The one that you install yourself (the readme says to) and the version that's listed in the package.json dependencies.

This causes the library to crash with this error:
image

sidenote: For me, I had already installed @react-native-picker/picker v2 and was using it before this package. And it was breaking due to this package installing v1 as well. I believe this is a good usecase for peerDependencies.

Solution

Move @react-native-picker/picker to peerDependencies in package.json. Keep separate install step in readme.

@kivohin
Copy link

kivohin commented Nov 8, 2021

When can we expect this PR to be merged in? 🙂

Nice work @Rehubbard!

This should solve both these 2 open issues:

@Rehubbard
Copy link
Author

@lfkwtz any updates on merging this PR? Is there anything else I can do to help it move along in the process?

Just ran into this issue again when upgrading our entire project and all dependencies. Thanks in advance!

@rushatgabhane
Copy link

@juaal12 @kivohin any updates merging this PR? Thanks

@LucioChavezFuentes
Copy link

@react-native-picker/picker released a new version that fixes a problem on ref prop in Web version but I can not use the updated version using react-native-picker-select. I tested this pull request on my project and fixes my problem. I see the changes have been approved but not merged. Is there any problem on merging? Is there something I could do? @juaal12 @kivohin Thank you for your time.

@luacmartins
Copy link

Hey @juaal12 @kivohin! Is there any update on merging this PR? Thank you so much!

@aldo-expensify
Copy link

aldo-expensify commented Mar 22, 2022

Seems like the auto-merge failed because of

Screen Shot 2022-03-22 at 2 58 27 PM

Could the codeclimate stuff be re-triggered by doing something like what was done here (rebase + force push)?

bbc/simorgh#143 (comment)
bbc/simorgh#130 (comment)

@rikur
Copy link

rikur commented Mar 30, 2022

@Rehubbard please see above

@keithdmoore
Copy link

Any updates? I realize the owners @LawnStarterTeam may not have time to properly maintain this library. However, maybe give others the access needed so that it can be maintained. Let the community help! It beats having hundreds of forks where others are likely making the some of the same changes and possibly adding new features that will never be incorporated because the PRs aren't getting merged.

@lfkwtz
Copy link
Collaborator

lfkwtz commented Aug 28, 2023

seems like lockfile changes are missing from this, no?

@lfkwtz
Copy link
Collaborator

lfkwtz commented Aug 28, 2023

@Rehubbard can you also bump to ^2.4.0?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet