-
Notifications
You must be signed in to change notification settings - Fork 492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Scroll to TextInput on picker opening #496
Open
chrispader
wants to merge
20
commits into
lawnstarter:master
Choose a base branch
from
chrispader:fix/scroll-to-input-on-open-upstream
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
4f433a6
fix: scroll to TextInput on picker opening
chrispader e8102fa
Merge branch 'master' into fix/scroll-to-input-on-open-upstream
chrispader 83cae10
feat: improve modal height measuring
chrispader e2652a4
fix: remove yarn.lock changes
chrispader 9ef8cd3
fix: update yarn.lock
chrispader baeaf11
fix: dependencies
chrispader a4953d5
chore: add jest support to eslint
chrispader 072d68e
test: add dummy test
chrispader 05f6bf5
fix: disable test temporarily
chrispader bea7157
Merge branch 'master' into fix/scroll-to-input-on-open-upstream
chrispader 3249e81
fix: move function to class function
chrispader b32c1f9
Merge branch 'master' into fix/scroll-to-input-on-open-upstream
lfkwtz d4689fb
Merge branch 'master' into fix/scroll-to-input-on-open-upstream
lfkwtz f29820b
add jsdom environment to auto scroll test
chrispader cd17731
move setup to after env
chrispader bd8d4cc
update packages
chrispader 77d81b4
update jest
chrispader 58b6ed2
don't update jest
chrispader 0e57b79
add react-native env
chrispader 8751709
remove jsom comment
chrispader File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested with iPhone SE / Mini variants too?
also - does landscape mode work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also - ipads?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, it was compatible, but i just made some improvements 👍 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great. able to add tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey, sorry for the late reply...
i think it's difficult to add tests here, because this is basically an iOS specific feature. With
jest
/enzyme
we can only test in a mocked environment.I added a dummy test, that reflects a test for this functionality, but this will not work in a web environnment