Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace-c-style-format-with-f-strings #1799

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

replace-c-style-format-with-f-strings #1799

wants to merge 3 commits into from

Conversation

nicksonlangat
Copy link
Contributor

No description provided.

longhotsummer
longhotsummer requested changes Sep 11, 2023
View reviewed changes
Copy link
Contributor

@longhotsummer longhotsummer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @nicksonlangat thanks for this, and sorry for the delay. It looks good, just the one with the translation which should be undone.

@nicksonlangat
Copy link
Contributor Author

Hi @nicksonlangat thanks for this, and sorry for the delay. It looks good, just the one with the translation which should be undone.

Updated pr

@longhotsummer
Copy link
Contributor

Thanks. Holding off until #1827 is merged which should fix the tests.

@longhotsummer
Copy link
Contributor

@nicksonlangat pls merge master into your branch, that should fix the tests.

@nicksonlangat
Copy link
Contributor Author

@nicksonlangat pls merge master into your branch, that should fix the tests.

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@longhotsummer longhotsummer longhotsummer requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nicksonlangat @longhotsummer