Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add brightness as a supported feature #6

Merged
merged 2 commits into from
Jun 17, 2020
Merged

Add brightness as a supported feature #6

merged 2 commits into from
Jun 17, 2020

Conversation

samlambert
Copy link
Contributor

Fixes #5

@samlambert samlambert mentioned this pull request Apr 17, 2020
Closed
@adam1010
Copy link

This patch added the brightness bar! (Tested on Core 0.108.5)

However, it also adds the bar for switches that aren't dimmable (ie configuration has switch_only: true). Ideally this new function would use the value from the switch_only config to decide whether or not to allow changes to brightness.

@samlambert
Copy link
Contributor Author

Thank you for the feedback @adam1010. I've added a commit to address this.

@lawtancool lawtancool merged commit 890ad19 into lawtancool:master Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Brightness bar doesn't show up
3 participants
@samlambert @adam1010 @lawtancool