Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #388 - Fixed locale causing imporper double parsing #420

Merged
merged 7 commits into from Nov 12, 2022

Conversation

ScrubN
Copy link
Collaborator

@ScrubN ScrubN commented Nov 8, 2022

Fixes #388

Also some formatting inconsistencies, like some if()s without braces

@lay295
Copy link
Owner

lay295 commented Nov 8, 2022

I think it's just passing CultureInfo.CurrentCulture as the second parameter like double.Parse(text, CultureInfo.CurrentCulture)

@ScrubN
Copy link
Collaborator Author

ScrubN commented Nov 8, 2022

Yeah I just remembered that. Submitting that now

@lay295 lay295 merged commit 0d2c068 into lay295:master Nov 12, 2022
@ScrubN ScrubN deleted the gui-chatrender-patch branch November 12, 2022 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chat render taking a long time?
2 participants