Add additional information to chat jsons #440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScrubN
changed the title
ScrubN
changed the title
…ated class, add ChatRootVersion operators and methods
lay295
pushed a commit
that referenced
this pull request
Dec 11, 2022
* Move chatupdate functions to Core, prepare for additional update options, shorten chatupdate file/class names * Make chatdownload obey custom temp folder * Fixed all embeds being doubled with arg --embed-missing, fixed crash when embeddedData is null, made embed fetching async * Continue before processing the new embedded item * Implement chat crop moving * Rename an arg, add input = output warning, typo * Update readme * Prepare for fetching missing comments (needs #440), cleanup * Update readme * Make ChatUpdater task based * Add missing comment fetching, make default true bools nullable, add more progress reporters * Move chat crop above embed fetching due to dependency, cleanup * Fix comment appending not being fully thread-safe, add comment count report, ensure temp file is deleted, cleanup * Update readmes * Typo * Clarify ReportType enum, fix chatupdate progress reports, clamp chat crops, cleanup * Fix first party emotes not proprely checking for already added embedded emotes, fix emoji count check for Linux * Rename 'DownloadFormat' to 'ChatFormat', add exception for catching unsupported chatupdate formats * Fix future chat crop error when using non-json formats * Simplify switch expressions with pattern matching * Add GUI frontend for ChatUpdate, more UI consistency, cleanup * Fix clip chat updating, add enqueuing support * Add chat update to default settings * Didn't mean to stage that * Add output format conversion (input must still be json), cleanup * Add step counter to progress chatupdate reports * Add percent and universal constructor to ProgressReport class, add percent reports to chatupdate * Use async methods with text chat writer, combine ParseChatJson and ParseChatJsonInfo, cleanup * Update 'what can it do' section in readme * Cleanup PreParseArgs, fix #448 * Fix NRE caused by 4867ddb, fix catch block in TwitchHelper * Better solution than 552ba3b, add additional icon sizes * Add build instructions to README, remove last traces of .Net Framework, other README improvements * Fix StatusInfo not fully overwriting the previous status, Move json, html, txt chat operations to dedicated classes, Fix sample text height being computed every render tick as it is expensive, Rewrite SubstringToTextWidth() to use spans, Cleanup * Sealed core runmode classes, minor TwitchHelper optimizations, convert emoji check from LINQ to foreach (faster), use arrays instead of lists, stringbuilders instead of strings where possible, combine some Rtl and non-Rtl functions, cleanup * Only use DrawShapedText() with messages containing RTL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TwitchObjects.GqlChatRootclass in namespaceTwitchObjectsChatRoot.VideoTimetoChatRoot.Videotitle,id,created_at, andlengthfields toChatRoot.VideoChatRootInfoclassChatRootVersionclass for keeping track of compatibilityI also created some unit tests to ensure sure the ChatRootVersion operators worked correctly. If you would like for these to be added this PR, I can do that. It could be nice to have some unit tests for several parts of Core