Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #848 add CLI mode to manually concatenate ts parts #888

Merged
merged 55 commits into from
Feb 25, 2024
Merged

Fixes #848 add CLI mode to manually concatenate ts parts #888

merged 55 commits into from
Feb 25, 2024

Conversation

superbonaci
Copy link
Contributor

No description provided.

Try to fix weird GitHub errors.
Set *.cs, *.xaml eol, replace tabs and non-ascii characters in THIRD-PARTY-LICENSES.txt
Catch ManagementExceptions when starting WindowsThemeService
Prerequisites for CLI filename template support (#886)
@ScrubN

This comment was marked as outdated.

@superbonaci
Copy link
Contributor Author

Merge it if you can, I think you can refactor later everything you need even add more features.

@ScrubN

This comment was marked as outdated.

@superbonaci
Copy link
Contributor Author

Thanks for the merge. I can't confirm wether the CopyToAsync method does always perform a raw concatenation or not, I'll have to ask people with deeper knowledge than me. All the recent tests I did recently do it.

@ScrubN

This comment was marked as outdated.

@ScrubN
Copy link
Collaborator

ScrubN commented Jan 23, 2024

I decided to make some of the changes myself, I hope you don't mind.

I also realized that limiting the user to M3U/M3U8 files was dumb, as it just requires the user to do more research before using the tool.

Copy link
Contributor Author

@superbonaci superbonaci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review

superbonaci and others added 5 commits February 2, 2024 11:28
If every part fails to verify, do not assume it is a false positive
More robust file extension assumption for CLI videodownload
Remove git commit hash from CLI banner when published in release mode
@ScrubN ScrubN merged commit 03ef16d into lay295:master Feb 25, 2024
@ScrubN
Copy link
Collaborator

ScrubN commented Feb 25, 2024

Sorry this took so long to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants