Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable audio packets interval #7

Closed
neckcen opened this issue Jan 21, 2015 · 6 comments
Closed

Configurable audio packets interval #7

neckcen opened this issue Jan 21, 2015 · 6 comments

Comments

@neckcen
Copy link

neckcen commented Jan 21, 2015

(Feature request)

Currently the interval at which audio packets are sent is hardcoded as 10milliseconds. This seems to produce choppy sound for me when using 10ms buffer in mumble. Would it be possible to allow custom audio interval values?

@ghost
Copy link

ghost commented Jan 22, 2015

Added in 334bf39.

@ghost ghost closed this as completed Jan 22, 2015
@neckcen
Copy link
Author

neckcen commented Jan 22, 2015

Did a quick test using the audio-player.go example with config.AudioInterval = 40 * time.Millisecond added and the sound is badly mangled (same with 20 and 60ms).

My own knowledge of Go proved itself insufficient to locate the source of the problem, sorry!

@ghost
Copy link

ghost commented Jan 22, 2015

The decrease in audio quality is likely due to Config.AudioDataBytes having a low value compared to the new interval. You can either:

  1. Manually change Config.AudioDataBytes to a larger value, or
  2. Use gumbleutil.AutoBitrate, which automatically sets Config.AudioDataBytes, based off of the server's maximum bitrate.

@neckcen
Copy link
Author

neckcen commented Jan 22, 2015

Adding client.Attach(gumbleutil.AutoBitrate) did change Config.AudioDataBytes value but did not help with sound quality.

@ghost
Copy link

ghost commented Jan 22, 2015

Can you make a recording of the audio and share it? Also, what is the bitrate of your server? It's worth nothing that it was reported that audio transmission does not work well on low-end devices such as the Raspberry Pi.

@neckcen
Copy link
Author

neckcen commented Jan 22, 2015

Server bitrate is 72kb/s (hosted on a server with 10mbs bandwidth). For the purpose of testing I am running the program from my desktop computer so performances shouldn't be an issue.

30s recordings straight from mumble:

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

1 participant