Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add alt text to the images in docs #116

Closed
iArchitSharma opened this issue Dec 13, 2023 · 9 comments 路 Fixed by #118
Closed

Add alt text to the images in docs #116

iArchitSharma opened this issue Dec 13, 2023 · 9 comments 路 Fixed by #118
Assignees
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@iArchitSharma
Copy link
Contributor

iArchitSharma commented Dec 13, 2023

Current Behavior

Currently, we do not have any alt text for 131 images on our site.
image

Expected Behavior

Please add meaningful alt text to as many images as possible.


Contributor Guides and Resources

@iArchitSharma iArchitSharma added good first issue Good for newcomers help wanted Extra attention is needed labels Dec 13, 2023
@surajvast1
Copy link
Contributor

I would like to work on this

@ayushlohmod
Copy link

I would like to work on this. Can you please assign it to me

@iArchitSharma
Copy link
Contributor Author

Assigning this to @surajvast1 on First come first serve basis
@ayushlohmod you can help us reviewing the PR

@surajvast1
Copy link
Contributor

Hey @iArchitSharma I am glad you gave me this i am new to meshery and just finished up my setup locally can you share the link of this page whose image you have uploaded it would really help like are they images of a particular file or whole website

@nwanduka
Copy link
Contributor

nwanduka commented Dec 18, 2023

@iArchitSharma, could you share the link to the site containing the images that need their alt text added? The image you shared is not opening on my end. And @surajvast1 needs the link to get started on this issue.

@iArchitSharma
Copy link
Contributor Author

@surajvast1 @nwanduka, I don't have access to these links either. So, the only way to work on this issue is by manually inspecting the codebase or by pasting this code into the console panel to list all images without alt text of that particular page console.table($$('img').filter(i => !i.alt), ['src'])

@nwanduka
Copy link
Contributor

Oh thanks a lot @iArchitSharma . I can view the attached image now and I think it has all the information needed to get started on the task. Thanks for also offering more clues on how to go about it. @surajvast1, you should be able to proceed now.

@surajvast1
Copy link
Contributor

I am still working on it in parts

@surajvast1
Copy link
Contributor

surajvast1 commented Dec 22, 2023

Thank you for assigning me the issue. I believe I have addressed most or all of the images. If there are any remaining images, please feel free to leave a comment

leecalcote added a commit that referenced this issue Dec 26, 2023
Solved Add alt text to the images in docs #116
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Development

Successfully merging a pull request may close this issue.

4 participants