Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small issue in the vertical navbar #350 omesh-omg #351

Closed

Conversation

omesh-omg
Copy link
Contributor

@omesh-omg omesh-omg commented Nov 21, 2023

Description
changes in the css to keep the text within the nav-bar
This PR fixes #350

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

Copy link

netlify bot commented Nov 21, 2023

Website preview ready!

Name Link
🔨 Latest commit dcb0e68
🔍 Latest deploy log https://app.netlify.com/sites/getnighthawk/deploys/655c1b1ca8f4a300089df3b0
😎 Deploy Preview https://deploy-preview-351--getnighthawk.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

omesh-omg and others added 4 commits November 21, 2023 08:05
Signed-off-by: omesh-omg <kumawatomesh4022@gmail.com>
Signed-off-by: omesh-omg <kumawatomesh4022@gmail.com>
Updated nighthawk.json with new discussion posts
@abhijeetgauravm
Copy link
Contributor

Hey @omesh-omg Please sign-off your commit to pass DCO check.

@omesh-omg
Copy link
Contributor Author

Okay

Copy link
Contributor

@abhijeetgauravm abhijeetgauravm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@omesh-omg the changes looks good. Please sign-off your commits to pass DCO!
image
One suggestion from my side would be, can we adjust hamburger menu towards right end(screen width ~412 -768 px), as u can see it's not looking appealing!

@omesh-omg
Copy link
Contributor Author

image
I have already signed off commit here in the last commit @abhijeetgauravm if u can access it please try or I will submit another pull request

@omesh-omg
Copy link
Contributor Author

@abhijeetgauravm also the hamburger menu problem is in another issue it is only visible in the native build or the one we run on our system on the live version we can't see the hamburger menu It is some technical fault it is already solved by someone and merged but it doesn't show up in the deployed website as I read in the pull request discussion
here are the links:
#258
you can check it out here you will get to know clearly

@iArchitSharma
Copy link

Closing this PR as duplicate exist #356

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] small issue in the vertical navbar link css
3 participants