Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Issue #9 #10

Merged
merged 1 commit into from
Dec 6, 2021
Merged

Fix Issue #9 #10

merged 1 commit into from
Dec 6, 2021

Conversation

tangledbytes
Copy link
Member

Signed-off-by: Utkarsh Srivastava srivastavautkarsh8097@gmail.com

Description
Location is marked as a required option now, hence running the binary without specifying the "location" flag returns a descriptive error rather than "panicking".

This PR fixes #9

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

@tangledbytes
Fix Issue #9
4d548dc 
Location is marked as a required option now, hence running the binary
without specifying the "location" flag returns a descriptive error
rather than "panicking"

Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com>
@tangledbytes tangledbytes mentioned this pull request Dec 6, 2021
Closed
Revolyssup
Revolyssup approved these changes Dec 6, 2021
View reviewed changes
Copy link
Contributor

@Revolyssup Revolyssup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tangledbytes tangledbytes merged commit fb6621a into master Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Revolyssup Revolyssup Revolyssup approved these changes

@leecalcote leecalcote Awaiting requested review from leecalcote

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing parameters unhandled
2 participants
@tangledbytes @Revolyssup