Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Make the path to the welcome image relative #7

Merged
merged 1 commit into from
Oct 27, 2020
Merged

fix: Make the path to the welcome image relative #7

merged 1 commit into from
Oct 27, 2020

Conversation

HeroicHitesh
Copy link
Contributor

@HeroicHitesh HeroicHitesh commented Oct 26, 2020 •
edited
Loading

Description
Make the path to the welcome image relative

This PR fixes #6

Signed commits

  • Yes, I signed my commits.

@welcome
Copy link

welcome bot commented Oct 26, 2020

Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Community Welcome Guide and sure to join the community Slack.
Be sure to double-check that you have signed your commits. Here are instructions for making signing an implicit activity while peforming a commit.

leecalcote
leecalcote previously approved these changes Oct 26, 2020
View reviewed changes
Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @HeroicHitesh. 👍

@leecalcote
Copy link
Member

@HeroicHitesh will you take a moment to sign-off on your commit here? You can do so by following executing these instructions - https://github.com/layer5io/layer5-repo-template/pull/7/checks?check_run_id=1310222917.

See the welcome message above for how to have your committed automatically signed-off.

@HeroicHitesh
fix: Make the path to the welcome image relative
5eab852 
Fixes layer5io#6
Signed-off-by: HeroicHitesh <hiteshkumar_1mv17cs042@sirmvit.edu>
@HeroicHitesh
Copy link
Contributor Author

HeroicHitesh commented Oct 27, 2020 •
edited
Loading

@HeroicHitesh will you take a moment to sign-off on your commit here?

@leecalcote Done

@leecalcote leecalcote merged commit 51e14c5 into layer5io:master Oct 27, 2020
@welcome
Copy link

welcome bot commented Oct 27, 2020 •
edited by leecalcote
Loading

Thanks for your contribution to the Layer5 community! 🎉

Congrats!

@leecalcote
Copy link
Member

Thanks for giving this a shot, @HeroicHitesh. Will you take another crack at it (see the message from the Welcome bot above)?

@leecalcote leecalcote mentioned this pull request Oct 27, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leecalcote leecalcote leecalcote left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Thanks for your contribution to the Layer5 community! 🎉
2 participants
@HeroicHitesh @leecalcote